TrueCloudLab/linters
22
0
Fork 7
generated from TrueCloudLab/basic
Code Issues 5 Pull requests 1 Projects Releases 1 Packages Wiki Activity Actions

Re-adding Edits from PR #2 #5

Merged
fyrchik merged 1 commit from achuprov/linters:master into master 2023-07-31 12:21:12 +00:00
Conversation 3 Commits 1 Files changed 14 +146 -556
achuprov commented 2023-07-31 09:08:41 +00:00
Member
Copy link

This PR brings back changes made after PR #2 discussions that were mistakenly deleted

This PR brings back changes made after PR #2 discussions that were mistakenly deleted
achuprov added 1 commit 2023-07-31 09:08:42 +00:00
linters: refactoring
All checks were successful
Tests and linters / Build lib (pull_request) Successful in 53s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m2s
Details
Tests and linters / Tests (pull_request) Successful in 2m11s
Details
Tests and linters / Lint (pull_request) Successful in 6m51s
Details
53d601603d
achuprov requested review from storage-core-developers 2023-07-31 09:17:49 +00:00
achuprov requested review from storage-core-committers 2023-07-31 09:17:49 +00:00
dstepanov-yadro requested changes 2023-07-31 09:19:31 +00:00
Makefile Outdated
@ -1,8 +1,8 @@
OUT_DIR?=./.bin
PLUGIN_SOURCE?=main.go
OUT_DIR ?= ./.bin
dstepanov-yadro commented 2023-07-31 09:18:04 +00:00
Member
Copy link

I think it must be ./.bin -> ./bin as for other repos.

I think it must be `./.bin` -> `./bin` as for other repos.
achuprov commented 2023-07-31 09:33:31 +00:00
Author
Member
Copy link

fixed

fixed
dstepanov-yadro marked this conversation as resolved
achuprov force-pushed master from 53d601603d to 7ed0837300 2023-07-31 09:30:10 +00:00 Compare
dstepanov-yadro approved these changes 2023-07-31 09:54:56 +00:00
dstepanov-yadro commented 2023-07-31 09:56:12 +00:00
Member
Copy link

Change commit message to format [#XXX] linters: refactoring

Change commit message to format `[#XXX] linters: refactoring`
achuprov force-pushed master from 7ed0837300 to df29d08821 2023-07-31 10:00:03 +00:00 Compare
fyrchik reviewed 2023-07-31 12:01:53 +00:00
main.go
@ -9,14 +9,6 @@ var AnalyzerPlugin analyzerPlugin
type analyzerPlugin struct{}
// for version ci-lint < '1.5.4'.
fyrchik commented 2023-07-31 12:01:53 +00:00
Owner
Copy link

this comment was still helpful (in case someone encounters problems)

_this_ comment was still helpful (in case someone encounters problems)
achuprov commented 2023-07-31 12:24:32 +00:00
Author
Member
Copy link

The old interface from version 1.5.3 will work on version 1.5.4. This comment is for the case where there are several different interfaces.

The old interface from version 1.5.3 will work on version 1.5.4. This comment is for the case where there are several different interfaces.
fyrchik approved these changes 2023-07-31 12:01:55 +00:00
fyrchik commented 2023-07-31 12:02:14 +00:00
Owner
Copy link

Again, why dont we want to be compatible with <1.5.4 and >=1.5.4 at the same time?

Again, why dont we want to be compatible with `<1.5.4` and `>=1.5.4` at the same time?
dstepanov-yadro commented 2023-07-31 12:06:26 +00:00
Member
Copy link

Again, why dont we want to be compatible with <1.5.4 and >=1.5.4 at the same time?

It will be next PR, this PR is only fix of merge problems.

> Again, why dont we want to be compatible with `<1.5.4` and `>=1.5.4` at the same time? It will be next PR, this PR is only fix of merge problems.
fyrchik merged commit df29d08821 into master 2023-07-31 12:21:12 +00:00
fyrchik referenced this pull request from a commit 2023-07-31 12:21:13 +00:00
[#5] linters: refactoring
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/linters#5
No description provided.
Delete branch "achuprov/linters:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?