TrueCloudLab/multinet
22
0
Fork 3
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Check interface state (up/down) on initialization step #10

Merged
fyrchik merged 4 commits from dstepanov-yadro/multinet:fix/interface_state_check into master 2024-11-02 14:21:56 +00:00
Conversation 0 Commits 4 Files changed 6 +78 -15
dstepanov-yadro commented 2024-10-08 09:42:34 +00:00
Member
Copy link

subj + linter issues

subj + linter issues
dstepanov-yadro added 3 commits 2024-10-08 09:42:34 +00:00 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/interface_state_check from 276a87cde1 to 777dd889d4 2024-10-08 09:43:27 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-10-08 09:43:43 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-10-08 09:43:43 +00:00
dstepanov-yadro force-pushed fix/interface_state_check from 777dd889d4 to ee21dd73e0 2024-10-08 09:46:07 +00:00 Compare
fyrchik reviewed 2024-10-08 09:49:45 +00:00
dialer_hostname_test.go Outdated
@ -114,10 +114,12 @@ func testInterfacesV6() ([]Interface, error) {
type testInterface struct {
name string
addrs []net.Addr
down bool
fyrchik commented 2024-10-08 09:49:42 +00:00
Owner
Copy link

Is it used anywhere in tests?

Is it used anywhere in tests?
dstepanov-yadro commented 2024-10-08 11:01:25 +00:00
Author
Member
Copy link

Fixed: added test

Fixed: added test
dstepanov-yadro force-pushed fix/interface_state_check from ee21dd73e0 to f65c788d73 2024-10-08 11:01:20 +00:00 Compare
fyrchik approved these changes 2024-10-08 11:06:38 +00:00
fyrchik merged commit f65c788d73 into master 2024-10-08 11:06:46 +00:00
fyrchik referenced this pull request from a commit 2024-10-08 11:06:48 +00:00
[#10] health: Drop unused
fyrchik referenced this pull request from a commit 2024-10-08 11:06:48 +00:00
[#10] dialer: Drop nil error
fyrchik referenced this pull request from a commit 2024-10-08 11:06:48 +00:00
[#10] dialer: Fix formatting
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/multinet#10
No description provided.
Delete branch "dstepanov-yadro/multinet:fix/interface_state_check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?