TrueCloudLab/neo-go
8
0
Fork 0
mirror of https://github.com/nspcc-dev/neo-go.git synced 2024-11-29 23:33:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

mempool: swap checks in Add, fail fast

Browse source 
Checking for duplicates is easier than checking the balance, so it should be
done first.
This commit is contained in:
Roman Khimov 2020-08-19 18:36:57 +03:00
parent e998c102ca
commit 0d8cc437fe
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/core/mempool/mem_pool.go
View file

@ -136,14 +136,14 @@ func (mp *Pool) Add(t *transaction.Transaction, fee Feer) error {
timeStamp: time.Now().UTC(), timeStamp: time.Now().UTC(),
} }
mp.lock.Lock() mp.lock.Lock()
if !mp.checkTxConflicts(t, fee) {
mp.lock.Unlock()
return ErrConflict
}
if mp.containsKey(t.Hash()) { if mp.containsKey(t.Hash()) {
mp.lock.Unlock() mp.lock.Unlock()
return ErrDup return ErrDup
} }
if !mp.checkTxConflicts(t, fee) {
mp.lock.Unlock()
return ErrConflict
}
mp.verifiedMap[t.Hash()] = pItem mp.verifiedMap[t.Hash()] = pItem
// Insert into sorted array (from max to min, that could also be done // Insert into sorted array (from max to min, that could also be done