TrueCloudLab/neo-go
8
0
Fork 0
mirror of https://github.com/nspcc-dev/neo-go.git synced 2024-11-26 19:42:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

compiler: allow unnamed params for exported methods

Browse source 
Adjust the result of #2601.
This commit is contained in:
Anna Shaleva 2022-08-17 12:23:31 +03:00
parent 5d5455312a
commit 171364f07f
2 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/compiler/analysis.go
View file

@ -285,11 +285,12 @@ func (c *codegen) analyzeFuncUsage() funcUsage {
case *ast.FuncDecl: case *ast.FuncDecl:
name := c.getFuncNameFromDecl(pkgPath, n) name := c.getFuncNameFromDecl(pkgPath, n)
// exported functions are always assumed to be used // exported functions and methods are always assumed to be used
if isMain && n.Name.IsExported() || isInitFunc(n) || isDeployFunc(n) { if isMain && n.Name.IsExported() || isInitFunc(n) || isDeployFunc(n) {
diff[name] = true diff[name] = true
} }
if isMain && n.Name.IsExported() { // exported functions are not allowed to have unnamed parameters
if isMain && n.Name.IsExported() && n.Recv == nil {
if n.Type.Params.List != nil { if n.Type.Params.List != nil {
for i, param := range n.Type.Params.List { for i, param := range n.Type.Params.List {
if param.Names == nil { if param.Names == nil {

9
pkg/compiler/compiler_test.go
View file

@ -417,4 +417,13 @@ func TestUnnamedParameterCheck(t *testing.T) {
_, _, err := compiler.CompileWithOptions("test.go", strings.NewReader(src), nil) _, _, err := compiler.CompileWithOptions("test.go", strings.NewReader(src), nil)
require.NoError(t, err) require.NoError(t, err)
}) })
t.Run("method with unnamed params", func(t *testing.T) {
src := `
package testcase
type A int
func (rsv A) OnNEP17Payment(_ string, _ int, iface interface{}){}
`
_, _, err := compiler.CompileWithOptions("test.go", strings.NewReader(src), nil)
require.NoError(t, err) // it's OK for exported method to have unnamed params as it won't be included into manifest
})
} }