TrueCloudLab/neo-go
8
0
Fork 0
mirror of https://github.com/nspcc-dev/neo-go.git synced 2024-11-26 19:42:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1189 from nspcc-dev/remove-stale-storeblock-comment

Browse source 
core: remove stale storeBlock comment, fix #365
This commit is contained in:
Roman Khimov 2020-07-17 07:39:12 +03:00 committed by GitHub
commit 1af2c69644
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/core/blockchain.go
View file

@ -550,10 +550,9 @@ func (bc *Blockchain) processHeader(h *block.Header, batch storage.Batch, header
return nil return nil
} }
// TODO: storeBlock needs some more love, its implemented as in the original // storeBlock performs chain update using the block given, it executes all
// project. This for the sake of development speed and understanding of what // transactions with all appropriate side-effects and updates Blockchain state.
// is happening here, quite allot as you can see :). If things are wired together // This is the only way to change Blockchain state.
// and all tests are in place, we can make a more optimized and cleaner implementation.
func (bc *Blockchain) storeBlock(block *block.Block) error { func (bc *Blockchain) storeBlock(block *block.Block) error {
cache := dao.NewCached(bc.dao) cache := dao.NewCached(bc.dao)
appExecResults := make([]*state.AppExecResult, 0, 1+len(block.Transactions)) appExecResults := make([]*state.AppExecResult, 0, 1+len(block.Transactions))