TrueCloudLab/neo-go
8
0
Fork 0
mirror of https://github.com/nspcc-dev/neo-go.git synced 2024-11-30 09:33:36 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2220 from nspcc-dev/fix-no-args-in-rpc

Browse source 
rpc: correctly handle RPC invocations with no arguments, fix #2219
This commit is contained in:
Roman Khimov 2021-10-18 10:06:18 +03:00 committed by GitHub
commit 3bf3d489a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/rpc/request/txBuilder.go
View file

@ -127,6 +127,9 @@ func CreateFunctionInvocationScript(contract util.Uint160, method string, params
emit.Opcodes(script.BinWriter, opcode.PACK) emit.Opcodes(script.BinWriter, opcode.PACK)
} }
} }
if len(params) == 0 {
emit.Opcodes(script.BinWriter, opcode.NEWARRAY0)
}
emit.AppCallNoArgs(script.BinWriter, contract, method, callflag.All) emit.AppCallNoArgs(script.BinWriter, contract, method, callflag.All)
return script.Bytes(), nil return script.Bytes(), nil

4
pkg/rpc/request/tx_builder_test.go
View file

@ -22,10 +22,10 @@ func TestInvocationScriptCreationGood(t *testing.T) {
script string script string
}{{ }{{
ps: Params{{Type: StringT, Value: "transfer"}}, ps: Params{{Type: StringT, Value: "transfer"}},
script: "1f0c087472616e736665720c146f459162ceeb248b071ec157d9e4f6fd26fdbe5041627d5b52", script: "c21f0c087472616e736665720c146f459162ceeb248b071ec157d9e4f6fd26fdbe5041627d5b52",
}, { }, {
ps: Params{{Type: NumberT, Value: 42}}, ps: Params{{Type: NumberT, Value: 42}},
script: "1f0c0234320c146f459162ceeb248b071ec157d9e4f6fd26fdbe5041627d5b52", script: "c21f0c0234320c146f459162ceeb248b071ec157d9e4f6fd26fdbe5041627d5b52",
}, { }, {
ps: Params{{Type: StringT, Value: "m"}, {Type: BooleanT, Value: true}}, ps: Params{{Type: StringT, Value: "m"}, {Type: BooleanT, Value: true}},
script: "11db201f0c016d0c146f459162ceeb248b071ec157d9e4f6fd26fdbe5041627d5b52", script: "11db201f0c016d0c146f459162ceeb248b071ec157d9e4f6fd26fdbe5041627d5b52",