From 50cb0450f25d61d3a4bd5577de480a5a5348b212 Mon Sep 17 00:00:00 2001 From: Roman Khimov Date: Thu, 13 May 2021 00:06:08 +0300 Subject: [PATCH] circleci/workflows: drop vet run golangci-lint already includes govet, so having it in a separate task doesn't add any value (only increases CI running time). --- .circleci/config.yml | 14 -------------- .github/workflows/run_tests.yml | 24 ------------------------ docs/release-instruction.md | 1 - 3 files changed, 39 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 17e8ac260..b2353748f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -44,16 +44,6 @@ jobs: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.40.0 make lint - vet: - working_directory: /go/src/github.com/nspcc-dev/neo-go - executor: go1_16 - steps: - - checkout - - gomod - - run: - name: go-vet - command: go vet ./... - test_1_14: working_directory: /go/src/github.com/nspcc-dev/neo-go executor: go1_14 @@ -123,10 +113,6 @@ workflows: version: 2 workflow: jobs: - - vet: - filters: - tags: - only: v/[0-9]+\.[0-9]+\.[0-9]+/ - lint: filters: tags: diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml index 8fecf7582..43d4587e3 100644 --- a/.github/workflows/run_tests.yml +++ b/.github/workflows/run_tests.yml @@ -25,30 +25,6 @@ jobs: with: version: latest - vet: - name: Vet - runs-on: ubuntu-18.04 - - steps: - - uses: actions/checkout@v2 - - - name: Set up Go - uses: actions/setup-go@v2 - with: - go-version: 1.16 - - - name: Restore Go modules from cache - uses: actions/cache@v2 - with: - path: /home/runner/go/pkg/mod - key: deps-${{ hashFiles('go.sum') }} - - - name: Update Go modules - run: go mod download -json - - - name: Run vet - run: go vet ./... - test_cover: name: Coverage runs-on: ubuntu-18.04 diff --git a/docs/release-instruction.md b/docs/release-instruction.md index bd02b1fc1..6310de5b9 100644 --- a/docs/release-instruction.md +++ b/docs/release-instruction.md @@ -8,7 +8,6 @@ list for a new release. These should run successfuly: * build * unit-tests - * vet * lint * privnet with consensus nodes