From c90f6785b96aa93e6a164dddb9c1ecc9e171d97c Mon Sep 17 00:00:00 2001
From: Anna Shaleva <shaleva.ann@nspcc.ru>
Date: Fri, 17 May 2024 13:35:54 +0300
Subject: [PATCH] native: perform initialisation for the set of hardforks

Close #3433.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
---
 pkg/core/native/management.go | 31 +++++++++++++++++++++++--------
 1 file changed, 23 insertions(+), 8 deletions(-)

diff --git a/pkg/core/native/management.go b/pkg/core/native/management.go
index b2a961f99..2633f6f8a 100644
--- a/pkg/core/native/management.go
+++ b/pkg/core/native/management.go
@@ -597,10 +597,11 @@ func (m *Management) OnPersist(ic *interop.Context) error {
 	var cache *ManagementCache
 	for _, native := range ic.Natives {
 		var (
-			activeIn = native.ActiveIn()
-			isDeploy bool
-			isUpdate bool
-			latestHF config.Hardfork
+			activeIn         = native.ActiveIn()
+			isDeploy         bool
+			isUpdate         bool
+			latestHF         config.Hardfork
+			currentActiveHFs []config.Hardfork
 		)
 		activeHFs := native.Metadata().ActiveHFs
 		isDeploy = activeIn == nil && ic.Block.Index == 0 ||
@@ -611,16 +612,18 @@ func (m *Management) OnPersist(ic *interop.Context) error {
 					isUpdate = true
 					activation := hf       // avoid loop variable pointer exporting.
 					activeIn = &activation // reuse ActiveIn variable for the initialization hardfork.
-					// Break immediately since native Initialize should be called only for the first hardfork in a raw
+					// Break immediately since native Initialize should be called starting from the first hardfork in a raw
 					// (if there are multiple hardforks with the same enabling height).
 					break
 				}
 			}
 		}
-		// Search for the latest active hardfork to properly construct manifest.
+		// Search for the latest active hardfork to properly construct manifest and
+		// initialize natives for the range of active hardforks.
 		for _, hf := range config.Hardforks {
 			if _, ok := activeHFs[hf]; ok && ic.IsHardforkActivation(hf) {
 				latestHF = hf
+				currentActiveHFs = append(currentActiveHFs, hf)
 			}
 		}
 		if !(isDeploy || isUpdate) {
@@ -654,9 +657,21 @@ func (m *Management) OnPersist(ic *interop.Context) error {
 		if err != nil {
 			return fmt.Errorf("failed to put contract state: %w", err)
 		}
-		if err := native.Initialize(ic, activeIn, hfSpecificMD); err != nil {
-			return fmt.Errorf("initializing %s native contract at HF %d: %w", md.Name, activeIn, err)
+
+		// Deploy hardfork (contract's ActiveIn) is not a part of contract's active hardforks and
+		// allowed to be nil, this, a special initialization call for it.
+		if isDeploy {
+			if err := native.Initialize(ic, activeIn, hfSpecificMD); err != nil {
+				return fmt.Errorf("initializing %s native contract at HF %v: %w", md.Name, activeIn, err)
+			}
 		}
+		// The rest of activating hardforks also require initialization.
+		for _, hf := range currentActiveHFs {
+			if err := native.Initialize(ic, &hf, hfSpecificMD); err != nil {
+				return fmt.Errorf("initializing %s native contract at HF %d: %w", md.Name, activeIn, err)
+			}
+		}
+
 		if cache == nil {
 			cache = ic.DAO.GetRWCache(m.ID).(*ManagementCache)
 		}