TrueCloudLab/neo-go
8
0
Fork 0
mirror of https://github.com/nspcc-dev/neo-go.git synced 2024-12-01 23:45:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

vm: fix a bug in collection serialize

Browse source 
When encountering already seen stack item we should fail
only if it is a collection. Duplicate Integers or ByteArrays are ok
because they can't lead to recursion.
This commit is contained in:
Evgenii Stratonikov 2019-11-15 12:47:58 +03:00
parent e740fbe708
commit 7080b78a6b
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/vm/serialization.go
View file

@ -33,7 +33,6 @@ func serializeItemTo(item StackItem, w *io.BinWriter, seen map[StackItem]bool) {
w.Err = errors.New("recursive structures are not supported") w.Err = errors.New("recursive structures are not supported")
return return
} }
seen[item] = true
switch t := item.(type) { switch t := item.(type) {
case *ByteArrayItem: case *ByteArrayItem:
@ -48,6 +47,8 @@ func serializeItemTo(item StackItem, w *io.BinWriter, seen map[StackItem]bool) {
case *InteropItem: case *InteropItem:
w.Err = errors.New("not supported") w.Err = errors.New("not supported")
case *ArrayItem, *StructItem: case *ArrayItem, *StructItem:
seen[item] = true
_, isArray := t.(*ArrayItem) _, isArray := t.(*ArrayItem)
if isArray { if isArray {
w.WriteLE(byte(arrayT)) w.WriteLE(byte(arrayT))
@ -61,6 +62,8 @@ func serializeItemTo(item StackItem, w *io.BinWriter, seen map[StackItem]bool) {
serializeItemTo(arr[i], w, seen) serializeItemTo(arr[i], w, seen)
} }
case *MapItem: case *MapItem:
seen[item] = true
w.WriteLE(byte(mapT)) w.WriteLE(byte(mapT))
w.WriteVarUint(uint64(len(t.value))) w.WriteVarUint(uint64(len(t.value)))
for k, v := range t.value { for k, v := range t.value {

11
pkg/vm/vm_test.go
View file

@ -379,6 +379,17 @@ func TestSerializeArrayBad(t *testing.T) {
require.True(t, vm.HasFailed()) require.True(t, vm.HasFailed())
} }
func TestSerializeDupInteger(t *testing.T) {
prog := []byte{
byte(PUSH0), byte(NEWARRAY),
byte(DUP), byte(PUSH2), byte(DUP), byte(TOALTSTACK), byte(APPEND),
byte(DUP), byte(FROMALTSTACK), byte(APPEND),
}
vm := load(append(prog, getSerializeProg()...))
runVM(t, vm)
}
func TestSerializeStruct(t *testing.T) { func TestSerializeStruct(t *testing.T) {
vm := load(getSerializeProg()) vm := load(getSerializeProg())
item := NewStructItem([]StackItem{ item := NewStructItem([]StackItem{