From 7c48177bf787491db3d559e8fdbbf98f2b9a40e0 Mon Sep 17 00:00:00 2001 From: AnnaShaleva Date: Wed, 17 Nov 2021 16:42:09 +0300 Subject: [PATCH] io: fix TestMakeDirForFile* tests Problem: ``` --- FAIL: TestMakeDirForFile_HappyPath (0.01s) testing.go:894: TempDir RemoveAll cleanup: remove C:\Users\Anna\AppData\Local\Temp\TestMakeDirForFile_HappyPath402638411\001\testDir\testFile.test: The process cannot access the file because it is being used by another process. --- FAIL: TestMakeDirForFile_Negative (0.01s) testing.go:894: TempDir RemoveAll cleanup: remove C:\Users\Anna\AppData\Local\Temp\TestMakeDirForFile_Negative672737582\001\testFile.test: The process cannot access the file because it is being used by another process. FAIL ``` Solution: Release resources occupied by os.Create. --- pkg/io/fileWriter_test.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pkg/io/fileWriter_test.go b/pkg/io/fileWriter_test.go index 65b0f872e..5a69135f4 100644 --- a/pkg/io/fileWriter_test.go +++ b/pkg/io/fileWriter_test.go @@ -10,19 +10,21 @@ import ( func TestMakeDirForFile_HappyPath(t *testing.T) { tempDir := t.TempDir() - filePath := path.Join(tempDir, "testDir/testFile.test") + filePath := path.Join(tempDir, "testDir", "testFile.test") err := MakeDirForFile(filePath, "test") require.NoError(t, err) - _, errChDir := os.Create(filePath) + f, errChDir := os.Create(filePath) require.NoError(t, errChDir) + require.NoError(t, f.Close()) } func TestMakeDirForFile_Negative(t *testing.T) { tempDir := t.TempDir() filePath := path.Join(tempDir, "testFile.test") - _, err := os.Create(filePath) + f, err := os.Create(filePath) require.NoError(t, err) + require.NoError(t, f.Close()) filePath = path.Join(filePath, "error") err = MakeDirForFile(filePath, "test")