Roman Khimov
1b83dc2476
*: improve for loop syntax
...
Mostly it's about Go 1.22+ syntax with ranging over integers, but it also
prefers ranging over slices where possible (it makes code a little better to
read).
Notice that we have a number of dangerous loops where slices are mutated
during loop execution, many of these can't be converted since we need proper
length evalutation at every iteration.
Signed-off-by: Roman Khimov <roman@nspcc.ru>
2024-08-30 21:45:18 +03:00
Roman Khimov
6d4ebdcef3
*: return errors.ErrUnsupported where appropriate
...
Signed-off-by: Roman Khimov <roman@nspcc.ru>
2024-08-27 12:51:12 +03:00
Roman Khimov
a1a7e3d708
*: use slices package for sorting and searching
...
Signed-off-by: Roman Khimov <roman@nspcc.ru>
2024-08-27 12:29:44 +03:00
Roman Khimov
f15a163cdf
rpcsrv: deduplicate RunForErrors code
...
Signed-off-by: Roman Khimov <roman@nspcc.ru>
2024-08-27 08:24:52 +03:00
Roman Khimov
d22bdd8369
rpcsrv: microoptimize result allocation
...
We know the size.
Signed-off-by: Roman Khimov <roman@nspcc.ru>
2024-08-27 08:24:52 +03:00
Roman Khimov
1c1d77c9b8
*: make use of min/max where appropriate
...
Signed-off-by: Roman Khimov <roman@nspcc.ru>
2024-08-23 22:11:29 +03:00
Anna Shaleva
afbb51e78c
rpcsrv: add test for Waiter constructor
...
Ensure that WSClient-based Actor is able to create EventBased waiter.
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-08-20 10:13:20 +03:00
Anna Shaleva
c06543cf50
*: fix linter issues
...
Linter is updated up to v1.60.1, the following issue is fixed:
```
predeclared variable max has same name as predeclared identifier
```
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-08-14 12:36:15 +03:00
Anna Shaleva
79e78980c4
Merge pull request #3552 from nspcc-dev/fix-wsclient-limit
...
rpcsrv: fix failing TestWSClientsLimit
2024-08-09 16:44:27 +03:00
Anna Shaleva
9ba6db491e
rpcsrv: fix failing TestWSClientsLimit
...
64 connections is too much for slow GA runners, we have to keep all of
them alive to avoid failures in the test, but it's impossible since
runners are too slow to iterate through all of them in time.
Close #3442 .
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-08-09 15:14:52 +03:00
Ekaterina Pavlova
9fb6d3266e
rpcsrv: add seedlist and standbycommittee to getversion
...
Port neo-project/neo#3443.
Close #3538
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-08-09 12:53:31 +03:00
Roman Khimov
f4b61b5a77
rpcsrv: set minimal default SessionExpirationTime to 5s, fix #3509
...
Signed-off-by: Roman Khimov <roman@nspcc.ru>
2024-07-26 17:17:37 +03:00
Anna Shaleva
434f94800a
rpcsrv: improve witness verification error
...
It's needed to give user a hint about what's wrong with the witness
during `calculatenetworkfee` RPC request processing.
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-07-11 12:03:34 +03:00
Anna Shaleva
c30e7ec8d7
native: bind CryptoLib's verifyWithECDsa changes to Cockatrice
...
A part of #3440 .
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-05-17 15:52:00 +03:00
Anna Shaleva
ce442a1942
rpcsrv: remove test for Koblitz-based witness verification
...
It will be built properly in #3447 .
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-05-17 15:45:04 +03:00
Anna Shaleva
e92606a7ae
native: bind Neo's CommitteeChanged event to Cockatrice
...
A part of #3440 .
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-05-17 15:22:29 +03:00
Roman Khimov
b1bb12df48
state: drop NativeContract, fix #3430
...
This unifies getnativecontracts RPC API with regular contracts.
Signed-off-by: Roman Khimov <roman@nspcc.ru>
2024-05-16 18:46:46 +03:00
Anna Shaleva
0aecddea10
native: autogenerate nativehashes package
...
Ref.
https://github.com/nspcc-dev/neo-go/pull/3402#discussion_r1577879141 .
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-05-14 09:39:53 +03:00
Anna Shaleva
6e0926e59f
native: adjust NamedCurveHash values
...
Use 122 and 123 respectively for Secp256k1Keccak256 and
Secp256r1Keccak256, ref.
https://github.com/neo-project/neo/pull/3209#issuecomment-2095798056 .
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-05-13 10:10:56 +03:00
Anna Shaleva
5053a073f9
rpcsrv: test calculatenetworkfee with custom Koblitz-based witness
...
Value calculated by calculatenetworkfee is enough to pass the real
tx verification. However, network fee may be decreased, so calculations
are not quite accurate. Need to investigate, why.
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-05-13 09:33:42 +03:00
Anna Shaleva
34eef47a18
native: extend CryptoLib's verifyWithECDsa with hasher parameter
...
Replace native CryptoLib's verifyWithECDsa `curve` parameter by
`curveHash` parameter which is a enum over supported pairs of named
curves and hash functions.
Even though this change is a compatible extension of the protocol, it
changes the genesis state due to parameter renaming. But we're going to
resync chain in 3.7 release anyway, so it's not a big deal.
Also, we need to check mainnet and testnet compatibility in case if
anyone has ever called verifyWithECDsa with 24 or 25 `curve` value.
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-05-13 09:33:41 +03:00
Anna Shaleva
ec6fc54bc6
*: use nativehashes package where possible
...
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-04-25 13:26:54 +03:00
Anna Shaleva
5c75ee13d0
config, native: introduce Cockatrice hard-fork
...
With all associated native API changes ported from
https://github.com/neo-project/neo/pull/2925 and
https://github.com/neo-project/neo/pull/3154 .
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-04-25 13:26:54 +03:00
Anna Shaleva
e5c919f701
rpcsrv: enforce WS connection close on test cleanup
...
Do not wait until wsReader routine gracefully finishes its work before
WS connection close. Instead, firstly close the connection, and after
that wait for proper wsReader exit.
It's a harsh way, but I don't have any other options to try, because
wsReader routine hangs on `ws.ReadMessage()` operation for more than
ReadDeadline (more than 5 seconds) during test cleanup which results in
the test timeout.
Close #3378 .
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-04-04 12:03:06 +03:00
Anna Shaleva
ef3ec190d0
rpcsrv: allow one-block slippage in TestWSClient_SubscriptionsCompat
...
Close #2956 . The failure reason is similar to the one described in #3396
for TestNotary: Blockchain's notificationDispatcher is listening to
block events from storeBlock via separate channel. By the moment single
block addition is finished, notification may or may not be properly
handled by notificationDispatcher, especially given the fact that our
runners are slow. As a result, assert.Eventually with 1-second awaiting
period may fail. This issue is solved by adding one more block, because
the second AddBlock finishes only when it sends block addition event to
notificationDispatcher loop, which means that the previous event was
handled.
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-04-04 11:02:15 +03:00
Ekaterina Pavlova
686c77aeea
rpcsrv: add SessionEnabled, MaxIteratorResultItems to getversion
...
Extend getversion RPC response with RPC server settings (SessionEnabled,
MaxIteratorResultItems).Port neo-project/neo-modules#878.
Close #3276
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-04-03 22:42:14 +03:00
Ekaterina Pavlova
f8c2d269fe
rpcsrv: increase timeout in TestWSClientsLimit
...
Still not fast enough for connections to be alive for the default case
of 64+1 connections. Some of them are start to die after 5 seconds of
test:
```
2024-04-03T14:06:22.5504034Z === RUN TestWSClientsLimit
2024-04-03T14:06:22.5504142Z === RUN TestWSClientsLimit/default
2024-04-03T14:06:22.5504868Z logger.go:146: 2024-04-03T14:04:30.637Z
INFO initial gas supply is not set or wrong, setting default
value {"InitialGASSupply": "52000000"}
2024-04-03T14:06:22.5505730Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO P2PNotaryRequestPayloadPool size is not set or wrong,
setting default value {"P2PNotaryRequestPayloadPoolSize": 1000}
2024-04-03T14:06:22.5506373Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO MaxBlockSize is not set or wrong, setting default
value {"MaxBlockSize": 262144}
2024-04-03T14:06:22.5507094Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO MaxBlockSystemFee is not set or wrong, setting default
value {"MaxBlockSystemFee": 900000000000}
2024-04-03T14:06:22.5507843Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO MaxTransactionsPerBlock is not set or wrong, using
default value {"MaxTransactionsPerBlock": 512}
2024-04-03T14:06:22.5508644Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO MaxValidUntilBlockIncrement is not set or wrong, using
default value {"MaxValidUntilBlockIncrement": 5760}
2024-04-03T14:06:22.5509114Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO no storage version found! creating genesis block
2024-04-03T14:06:22.5509788Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO ExtensiblePoolSize is not set or wrong, using default
value {"ExtensiblePoolSize": 20}
2024-04-03T14:06:22.5510476Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO SessionPoolSize is not set or wrong, setting default
value {"SessionPoolSize": 20}
2024-04-03T14:06:22.5511258Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO MaxIteratorResultItems is not set or wrong, setting
default value {"MaxIteratorResultItems": 100}
2024-04-03T14:06:22.5511951Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO MaxFindResultItems is not set or wrong, setting
default value {"MaxFindResultItems": 100}
2024-04-03T14:06:22.5512598Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO MaxNEP11Tokens is not set or wrong, setting default
value {"MaxNEP11Tokens": 100}
2024-04-03T14:06:22.5513316Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO MaxRequestBodyBytes is not set or wong, setting
default value {"MaxRequestBodyBytes": 5242880}
2024-04-03T14:06:22.5514060Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO MaxRequestHeaderBytes is not set or wong, setting
default value {"MaxRequestHeaderBytes": 1048576}
2024-04-03T14:06:22.5514755Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO MaxWebSocketClients is not set or wrong, setting
default value {"MaxWebSocketClients": 64}
2024-04-03T14:06:22.5515215Z logger.go:146: 2024-04-03T14:04:30
.637Z INFO starting rpc-server {"endpoint": "127.0.0.1:0"}
2024-04-03T14:06:22.5515874Z logger.go:146: 2024-04-03T14:04:31
.200Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5516442Z logger.go:146: 2024-04-03T14:04:31
.200Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5516973Z logger.go:146: 2024-04-03T14:04:31
.226Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5517502Z logger.go:146: 2024-04-03T14:04:31
.388Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5518027Z logger.go:146: 2024-04-03T14:04:31
.398Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5518551Z logger.go:146: 2024-04-03T14:04:31
.420Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5519082Z logger.go:146: 2024-04-03T14:04:31
.577Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5519606Z logger.go:146: 2024-04-03T14:04:31
.587Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5520133Z logger.go:146: 2024-04-03T14:04:31
.624Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5520850Z logger.go:146: 2024-04-03T14:04:31
.780Z INFO persisted to disk {"blocks": 0, "keys": 127,
"headerHeight": 0, "blockHeight": 0, "took": "121.8µs"}
2024-04-03T14:06:22.5521398Z logger.go:146: 2024-04-03T14:04:31
.780Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5521925Z logger.go:146: 2024-04-03T14:04:31
.812Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5522452Z logger.go:146: 2024-04-03T14:04:31
.969Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5522975Z logger.go:146: 2024-04-03T14:04:32
.016Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5523507Z logger.go:146: 2024-04-03T14:04:32
.172Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5524033Z logger.go:146: 2024-04-03T14:04:32
.219Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5524555Z logger.go:146: 2024-04-03T14:04:32
.273Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5525081Z logger.go:146: 2024-04-03T14:04:32
.376Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5525604Z logger.go:146: 2024-04-03T14:04:32
.423Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5526131Z logger.go:146: 2024-04-03T14:04:32
.563Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5526691Z logger.go:146: 2024-04-03T14:04:32
.627Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5527254Z logger.go:146: 2024-04-03T14:04:32
.767Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5527777Z logger.go:146: 2024-04-03T14:04:32
.830Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5528304Z logger.go:146: 2024-04-03T14:04:32
.955Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5528824Z logger.go:146: 2024-04-03T14:04:33
.033Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5529352Z logger.go:146: 2024-04-03T14:04:33
.158Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5529871Z logger.go:146: 2024-04-03T14:04:33
.237Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5530395Z logger.go:146: 2024-04-03T14:04:33
.322Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5530921Z logger.go:146: 2024-04-03T14:04:33
.348Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5531472Z logger.go:146: 2024-04-03T14:04:33
.444Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5532031Z logger.go:146: 2024-04-03T14:04:33
.535Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5532555Z logger.go:146: 2024-04-03T14:04:33
.645Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5533084Z logger.go:146: 2024-04-03T14:04:33
.724Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5533604Z logger.go:146: 2024-04-03T14:04:33
.848Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5534132Z logger.go:146: 2024-04-03T14:04:33
.926Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5534662Z logger.go:146: 2024-04-03T14:04:34
.036Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5535190Z logger.go:146: 2024-04-03T14:04:34
.130Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5535712Z logger.go:146: 2024-04-03T14:04:34
.224Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5536231Z logger.go:146: 2024-04-03T14:04:34
.318Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5536758Z logger.go:146: 2024-04-03T14:04:34
.413Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5537277Z logger.go:146: 2024-04-03T14:04:34
.423Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5537805Z logger.go:146: 2024-04-03T14:04:34
.423Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5538329Z logger.go:146: 2024-04-03T14:04:34
.523Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5538855Z logger.go:146: 2024-04-03T14:04:34
.602Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5539382Z logger.go:146: 2024-04-03T14:04:34
.612Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5539908Z logger.go:146: 2024-04-03T14:04:34
.712Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5540431Z logger.go:146: 2024-04-03T14:04:34
.805Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5540956Z logger.go:146: 2024-04-03T14:04:34
.915Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5541515Z logger.go:146: 2024-04-03T14:04:34
.993Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5542070Z logger.go:146: 2024-04-03T14:04:35
.118Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5542599Z logger.go:146: 2024-04-03T14:04:35
.181Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5543125Z logger.go:146: 2024-04-03T14:04:35
.307Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5543650Z logger.go:146: 2024-04-03T14:04:35
.385Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5544169Z logger.go:146: 2024-04-03T14:04:35
.426Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5544695Z logger.go:146: 2024-04-03T14:04:35
.510Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5545262Z logger.go:146: 2024-04-03T14:04:35
.589Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5545839Z logger.go:146: 2024-04-03T14:04:35
.698Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5546421Z logger.go:146: 2024-04-03T14:04:35
.777Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5547045Z logger.go:146: 2024-04-03T14:04:35
.902Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5547593Z logger.go:146: 2024-04-03T14:04:35
.980Z DEBUG processing rpc request {"method": "getversion",
"params": "[]"}
2024-04-03T14:06:22.5551421Z subscription_test.go:620:
2024-04-03T14:06:22.5551977Z Error Trace:
D:/a/neo-go/neo-go/pkg/services/rpcsrv/subscription_test.go:620
2024-04-03T14:06:22.5552611Z
C:/hostedtoolcache/windows/go/1.22.1/x64/src/runtime/asm_amd64.s:1695
2024-04-03T14:06:22.5552821Z Error: Received
unexpected error:
2024-04-03T14:06:22.5553328Z read tcp 127.0
.0.1:51969->127.0.0.1:51909: i/o timeout
2024-04-03T14:06:22.5553535Z Test:
TestWSClientsLimit/default
2024-04-03T14:06:22.5553676Z subscription_test.go:620:
2024-04-03T14:06:22.5554223Z Error Trace:
D:/a/neo-go/neo-go/pkg/services/rpcsrv/subscription_test.go:620
2024-04-03T14:06:22.5554831Z
C:/hostedtoolcache/windows/go/1.22.1/x64/src/runtime/asm_amd64.s:1695
2024-04-03T14:06:22.5555036Z Error: Received
unexpected error:
2024-04-03T14:06:22.5555521Z read tcp 127.0
.0.1:51970->127.0.0.1:51909: i/o timeout
2024-04-03T14:06:22.5555723Z Test:
TestWSClientsLimit/default
2024-04-03T14:06:22.5555860Z subscription_test.go:620:
2024-04-03T14:06:22.5556336Z Error Trace:
D:/a/neo-go/neo-go/pkg/services/rpcsrv/subscription_test.go:620
2024-04-03T14:06:22.5556953Z
C:/hostedtoolcache/windows/go/1.22.1/x64/src/runtime/asm_amd64.s:1695
2024-04-03T14:06:22.5557160Z Error: Received
unexpected error:
2024-04-03T14:06:22.5557636Z read tcp 127.0
.0.1:51973->127.0.0.1:51909: i/o timeout
2024-04-03T14:06:22.5557831Z Test:
TestWSClientsLimit/default
2024-04-03T14:06:22.5557967Z subscription_test.go:620:
2024-04-03T14:06:22.5558437Z Error Trace:
D:/a/neo-go/neo-go/pkg/services/rpcsrv/subscription_test.go:620
2024-04-03T14:06:22.5559028Z
C:/hostedtoolcache/windows/go/1.22.1/x64/src/runtime/asm_amd64.s:1695
2024-04-03T14:06:22.5559229Z Error: Received
unexpected error:
2024-04-03T14:06:22.5559696Z read tcp 127.0
.0.1:51971->127.0.0.1:51909: i/o timeout
2024-04-03T14:06:22.5559891Z Test:
TestWSClientsLimit/default
2024-04-03T14:06:22.5560024Z subscription_test.go:620:
2024-04-03T14:06:22.5560490Z Error Trace:
D:/a/neo-go/neo-go/pkg/services/rpcsrv/subscription_test.go:620
2024-04-03T14:06:22.5561142Z
C:/hostedtoolcache/windows/go/1.22.1/x64/src/runtime/asm_amd64.s:1695
2024-04-03T14:06:22.5561371Z Error: Received
unexpected error:
2024-04-03T14:06:22.5561849Z read tcp 127.0
.0.1:51972->127.0.0.1:51909: i/o timeout
2024-04-03T14:06:22.5562043Z Test:
TestWSClientsLimit/default
2024-04-03T14:06:22.5562179Z subscription_test.go:630:
2024-04-03T14:06:22.5562638Z Error Trace:
D:/a/neo-go/neo-go/pkg/services/rpcsrv/subscription_test.go:630
2024-04-03T14:06:22.5562879Z Error: An error is
expected but got nil.
2024-04-03T14:06:22.5563073Z Test:
TestWSClientsLimit/default
2024-04-03T14:06:22.5563361Z Messages: The connection
beyond the limit should fail
2024-04-03T14:06:22.5563886Z logger.go:146: 2024-04-03T14:04:36
.481Z INFO shutting down RPC server {"endpoint": "127.0.0
.1:51908"}
```
Close #3379
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-04-03 18:03:55 +03:00
Ekaterina Pavlova
698bdc7eea
rpcsrv: fix TestWSClientsLimit
...
Made connections in parallel to check the limit and attempt to make one
more connection beyond the limit. Only "default" test case is failing,
because default number of connections is 64 (quite large for slow
runners). The failure reason is:
* given ~1 second for [dealing + request] per connection (time is taken
from the test log)
* by the moment 65-th connection is reached, some connections from the
start of the test have died due to inactivity (this process literally
takes 1 minute)
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-04-03 18:03:55 +03:00
Roman Khimov
be1b97d04e
Merge pull request #3392 from nspcc-dev/adjust-deadlines
...
*: adjust WS connection RW deadlines
2024-04-03 14:50:14 +03:00
Anna Shaleva
29deba45ca
services: refactor test WS reader
...
1. Replace isFinished atomic variable with a channel, no functional changes
here, just use more common way as all our services do.
2. Do not check erors from SetReadDeadline and ReadMessage on exit. It
seems to be not quite right because connection is not closed by this
moment, and thus, these error checks are racy.
3. Add read timeout for the message reader. It is needed because some
tests may leave message unread in the end which results in hanging
test cleanup.
4. Add drain loop to message reader in order not to block WS reader on
sending message.
Ref. https://github.com/nspcc-dev/neo-go/pull/3392#issuecomment-2031590403 .
It's clear that TestBadSubUnsub is hanging on test cleanup, in
particular, on attempt to wait for wsRead routine to exit. The only
place where wsRead routine may hang is sending to msgCh in case if
receiver is not going to read from this channel:
```
2024-04-02T08:14:51.4957621Z goroutine 14329 [chan receive]:
2024-04-02T08:14:51.4958010Z github.com/nspcc-dev/neo-go/pkg/services/rpcsrv.initCleanServerAndWSClient.func1()
2024-04-02T08:14:51.4958344Z D:/a/neo-go/neo-go/pkg/services/rpcsrv/subscription_test.go:80 +0x71
2024-04-02T08:14:51.4958457Z testing.(*common).Cleanup.func1()
2024-04-02T08:14:51.4958757Z C:/hostedtoolcache/windows/go/1.22.1/x64/src/testing/testing.go:1175 +0x17a
2024-04-02T08:14:51.4958903Z testing.(*common).runCleanup(0xc002cf5860, 0x0)
2024-04-02T08:14:51.4959193Z C:/hostedtoolcache/windows/go/1.22.1/x64/src/testing/testing.go:1353 +0x262
2024-04-02T08:14:51.4959291Z testing.tRunner.func2()
2024-04-02T08:14:51.4959566Z C:/hostedtoolcache/windows/go/1.22.1/x64/src/testing/testing.go:1683 +0x51
2024-04-02T08:14:51.4959695Z testing.tRunner(0xc002cf5860, 0x141687410)
2024-04-02T08:14:51.4959976Z C:/hostedtoolcache/windows/go/1.22.1/x64/src/testing/testing.go:1695 +0x25e
2024-04-02T08:14:51.4960115Z created by testing.(*T).Run in goroutine 1
2024-04-02T08:14:51.4960385Z C:/hostedtoolcache/windows/go/1.22.1/x64/src/testing/testing.go:1742 +0x826
```
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-04-03 12:56:07 +03:00
Ekaterina Pavlova
fff25bd85c
rpcsrv: fix findstorage if a contract state is not found
...
Previously findstorage returns null for the results key if a contract
state is not found. C# returns an empty list.
Close #3370
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-04-02 19:56:44 +03:00
Ekaterina Pavlova
65dbd537ec
rpc: fix TestRPC timeout
...
Increase timeout to prevent `context deadline exceeded (Client.Timeout
exceeded while awaiting headers)`.
Close #2975
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-04-02 11:11:14 +03:00
Anna Shaleva
b947d09552
*: adjust WS connection RW deadlines
...
Yet another attempt to close #3378 .
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-04-02 10:31:38 +03:00
Anna Shaleva
5b30d15f8e
rpcsrv: properly cleanup network server in tests
...
Port the idea of https://github.com/nspcc-dev/neo-go/pull/3380 .
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-04-01 18:54:35 +03:00
Anna Shaleva
57d82c1281
rpcsrv: properly cleanup WS reader in tests
...
Close #3378 .
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-04-01 18:54:35 +03:00
Ekaterina Pavlova
56e6119f78
rpcsrv: fix TestSubClientWaitWithMissedEvent
...
Add error channel to prevent data race in the test.
Increase waiting interval for subscriptions awaiting up to 2 seconds.
Failing is caused by slow subscriptions.
Close #2958
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-04-01 10:52:13 +03:00
Ekaterina Pavlova
c090628ea5
rpcsrv: update block20StateRootLE
...
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-03-22 17:20:06 +03:00
Anna Shaleva
fa1c07e7e6
Merge pull request #3362 from nspcc-dev/getCommitteeAddress
...
native: add getCommitteeAddress method
2024-03-22 17:13:29 +03:00
Ekaterina Pavlova
72484a33eb
rpcsrv: update block20StateRootLE
...
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-03-22 16:46:59 +03:00
Ekaterina Pavlova
f409fc36e2
rpcsrv: fix TestRPC failing
...
Default http.Client and http.Transport can be really slow. Also on
windows Timeout: time.Second was not enough. Probably network related
issue. As mentioned in https://github
.com/nspcc-dev/neo-go/issues/2975#issuecomment-1750523651 forcely use
only tcp4 and FallbackDelay: -1. This made TestRPC little bit faster so
gh windows runner can manage it without timeout or POST request fails.
Close #2975
Close #3314
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-03-22 16:18:19 +03:00
Ekaterina Pavlova
7c2575568d
rpcsrv: update block20StateRootLE
...
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-03-19 23:00:06 +03:00
Roman Khimov
27f79b8c63
rpcsrv: fix insufficient funds use
...
This is not the way intended in https://github.com/neo-project/proposals/pull/156 .
-511 covers _both_ cases because users hardly can distinguish one from another,
it's just that our mempool implementation has error codes for both..
Signed-off-by: Roman Khimov <roman@nspcc.ru>
2024-03-18 20:37:39 +03:00
Anna Shaleva
82e52c4f6d
rpcsrv: fix RPC error codes proposal compatibility
...
mempool.ErrInsufficientFunds is used when sender doesn't have enough
balance to pay the submitted transaction fees (-511 code according to
https://github.com/neo-project/proposals/pull/156 ). mempool.ErrConflict is
used when sender is not able to pay the overall transactions fee sum in
the pool (generic -500 error according to the proposal).
This bugfix is kind of breaking change for those users who relied on the
old -511 code previously returning "insufficient funds" error.
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-03-18 18:05:19 +03:00
Anna Shaleva
335550fb1e
rpcsrv: generate randome nonce for RPC server test transactions
...
Avoid mempool conflicts in tests.
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-03-18 18:03:58 +03:00
Anna Shaleva
37d4012306
rpcsrv: properly close RPC clients in tests
...
This commit doesn't fix anything, but clients should be closed, it's
just a good practice.
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
2024-03-14 11:04:39 +03:00
Anna Shaleva
67d39177d8
Merge pull request #3350 from nspcc-dev/tune-rpc-tests
...
rpcsrv: close idle client connections in doRPCCallOverHTTP
2024-03-14 10:52:35 +03:00
Roman Khimov
86faf7b343
rpcsrv: close idle client connections in doRPCCallOverHTTP
...
Shouldn't affect things much, yet at the same time we no longer need any
connection after we're done with the request.
Signed-off-by: Roman Khimov <roman@nspcc.ru>
2024-03-13 12:58:15 +03:00
Ekaterina Pavlova
588d7c6418
rpcsrv: fix concurrent test TestClient_IteratorSessions
...
The default for `MaxConnsPerHost` is "no limit", so it'll use as many
connections as it can (potentially hitting MacOS/Windows limits
https://github.com/golang/go/issues/20960#issuecomment-447918270 ).
Close #3300
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-03-11 22:00:23 +03:00
Ekaterina Pavlova
ee39b5ca18
rpcsrv: add close of http server in tests
...
The HTTP server should be closed at the end of the test.
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-03-06 01:17:59 +03:00
Ekaterina Pavlova
46f2da0fb1
rpcsrv: add close of blockchain and rpc server in tests
...
The logs race issue is a result of improper shutdown during testing.
Close #3217
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
2024-03-06 01:17:59 +03:00