Roman Khimov 65016e8070 core: fix data race in notary test ... I don't think it's possible with regular service functioning, but it happens during testing because of pointer reuse: WARNING: DATA RACE Read at 0x00c003a0e3f0 by goroutine 114: github.com/nspcc-dev/neo-go/pkg/services/notary.(*Notary).verifyIncompleteWitnesses() /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:441 +0x1dc github.com/nspcc-dev/neo-go/pkg/services/notary.(*Notary).OnNewRequest() /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:188 +0x205 github.com/nspcc-dev/neo-go/pkg/core.TestNotary.func11() /home/runner/work/neo-go/neo-go/pkg/core/notary_test.go:347 +0x612 github.com/nspcc-dev/neo-go/pkg/core.TestNotary() /home/runner/work/neo-go/neo-go/pkg/core/notary_test.go:443 +0xe33 testing.tRunner() /opt/hostedtoolcache/go/1.16.10/x64/src/testing/testing.go:1193 +0x202 Previous write at 0x00c003a0e3f0 by goroutine 104: github.com/nspcc-dev/neo-go/pkg/services/notary.(*Notary).finalize() /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:338 +0x50a github.com/nspcc-dev/neo-go/pkg/services/notary.(*Notary).PostPersist() /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:314 +0x297 github.com/nspcc-dev/neo-go/pkg/services/notary.(*Notary).Run() /home/runner/work/neo-go/neo-go/pkg/services/notary/notary.go:169 +0x4a7		2021-11-15 17:33:02 +03:00
..
compiler	Merge pull request #2255 from nspcc-dev/compiler-noreturn-defers	2021-11-15 10:43:00 +03:00
config	rpc: implement findstates RPC handler	2021-10-13 11:41:05 +03:00
consensus	rpc: refactor calculatenetworkfee handler	2021-10-25 19:07:25 +03:00
core	core: fix data race in notary test	2021-11-15 17:33:02 +03:00
crypto	keys: reuse coordLen where appropriate	2021-08-26 17:30:04 +03:00
encoding	util: move ArrayReverse into package of its own	2021-07-19 22:57:55 +03:00
interop	compiler: remove custom logic for util builtins	2021-10-23 16:12:47 +03:00
io	*: make tests use TempDir(), fix #1319	2021-08-26 17:29:40 +03:00
neotest	neotest: allow to use 6-node committee	2021-11-11 11:15:15 +03:00
network	network: fix data race in TestHandleMPTData, fix #2241	2021-11-15 12:37:01 +03:00
rpc	rpc/server: use dynamic port for P2P service	2021-11-15 12:19:27 +03:00
services	rpc: refactor calculatenetworkfee handler	2021-10-25 19:07:25 +03:00
smartcontract	transaction: add new Rules witness scope	2021-11-12 15:29:28 +03:00
util	util: reduce allocations in util.Uint256DecodeStringLE	2021-08-17 16:53:39 +03:00
vm	vm: add PACKMAP/PACKSTRUCT, extend UNPACK	2021-11-12 17:19:59 +03:00
wallet	wallet: do not store file handle	2021-10-06 15:29:52 +03:00