mirror of
https://github.com/nspcc-dev/neo-go.git
synced 2024-11-22 09:29:38 +00:00
775c56e87e
Use started atomic.Bool field to ensure that the node server shutdown
procedure is executed only once. Prevent the following panic caused by
server double-shutdown in testing code:
```
--- FAIL: TestServerRegisterPeer (0
.06s)
panic: closed twice
goroutine 60 [running]:
testing.tRunner.func1.2({0x104c40b20, 0x104d0ec90})
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1545 +0x1c8
testing.tRunner.func1()
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1548 +0x360
panic({0x104c40b20?, 0x104d0ec90?})
/opt/homebrew/opt/go/libexec/src/runtime/panic.go:914 +0x218
github.com/nspcc-dev/neo-go/pkg/network.(*fakeTransp).Close
(0x14000159e08?)
/Users/ekaterinapavlova/Workplace/neo-go/pkg/network
/discovery_test.go:83 +0x54
github.com/nspcc-dev/neo-go/pkg/network.(*Server).Shutdown
(0x14000343400)
/Users/ekaterinapavlova/Workplace/neo-go/pkg/network/server.go:299
+0x104
github.com/nspcc-dev/neo-go/pkg/network.startWithCleanup.func1()
/Users/ekaterinapavlova/Workplace/neo-go/pkg/network/server_test
.go:408 +0x20
testing.(*common).Cleanup.func1()
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1169 +0x110
testing.(*common).runCleanup(0x1400032c340, 0x14000159d80?)
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1347 +0xd8
testing.tRunner.func2()
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1589 +0x2c
testing.tRunner(0x1400032c340, 0x104d0c5d0)
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1601 +0x114
created by testing.(*T).Run in goroutine 1
/opt/homebrew/opt/go/libexec/src/testing/testing.go:1648 +0x33c
```
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
|
||
|---|---|---|
| .. | ||
| bqueue | ||
| capability | ||
| extpool | ||
| payload | ||
| compress.go | ||
| discovery.go | ||
| discovery_test.go | ||
| fuzz_test.go | ||
| helper_test.go | ||
| message.go | ||
| message_string.go | ||
| message_test.go | ||
| notary_feer.go | ||
| peer.go | ||
| prometheus.go | ||
| server.go | ||
| server_config.go | ||
| server_test.go | ||
| state_sync.go | ||
| tcp_peer.go | ||
| tcp_peer_test.go | ||
| tcp_transport.go | ||
| transport.go | ||