From 0d17273476c5363a0b8c7ff76854ad6571cdccc2 Mon Sep 17 00:00:00 2001 From: Anna Shaleva Date: Fri, 14 Jul 2023 11:40:44 +0300 Subject: [PATCH] core: fix formatted error on transaction verification Witnesses are not yet created by the moment we return this error, thus, it was always 0 as an actual number of witnesses in ErrInvalidWitnessNum. Signed-off-by: Anna Shaleva --- pkg/core/transaction/transaction.go | 2 +- pkg/vm/testdata/neo-vm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/core/transaction/transaction.go b/pkg/core/transaction/transaction.go index 3c201d042..eba0c237d 100644 --- a/pkg/core/transaction/transaction.go +++ b/pkg/core/transaction/transaction.go @@ -193,7 +193,7 @@ func (t *Transaction) decodeBinaryNoSize(br *io.BinReader, buf []byte) { br.Err = errors.New("too many witnesses") return } else if int(nscripts) != len(t.Signers) { - br.Err = fmt.Errorf("%w: %d vs %d", ErrInvalidWitnessNum, len(t.Signers), len(t.Scripts)) + br.Err = fmt.Errorf("%w: %d vs %d", ErrInvalidWitnessNum, len(t.Signers), nscripts) return } t.Scripts = make([]Witness, nscripts) diff --git a/pkg/vm/testdata/neo-vm b/pkg/vm/testdata/neo-vm index 02f2c68e7..7e5996844 160000 --- a/pkg/vm/testdata/neo-vm +++ b/pkg/vm/testdata/neo-vm @@ -1 +1 @@ -Subproject commit 02f2c68e7ba2694aff88c143631e7acf158d378a +Subproject commit 7e5996844a90b514739f879bc9f873f9a34c9a67