Refactor of the Go node (#44)

* added headersOp for safely processing headers

* Better handling of protocol messages.

* housekeeping + cleanup tests

* Added more blockchain logic + unit tests

* fixed unreachable error.

* added structured logging for all (node) components.

* added relay flag + bumped version

pkg/core/blockchain_test.go

@@ -1,48 +1,70 @@
 package core
 
 import (
-	"log"
-	"os"
 	"testing"
 
-	"github.com/CityOfZion/neo-go/pkg/core/transaction"
 	"github.com/CityOfZion/neo-go/pkg/util"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestNewBlockchain(t *testing.T) {
 	startHash, _ := util.Uint256DecodeString("996e37358dc369912041f966f8c5d8d3a8255ba5dcbd3447f8a82b55db869099")
-	bc := NewBlockchain(nil, nil, startHash)
+	bc := NewBlockchain(nil, startHash)
 
-	want := uint32(0)
-	if have := bc.BlockHeight(); want != have {
-		t.Fatalf("expected %d got %d", want, have)
-	}
-	if have := bc.HeaderHeight(); want != have {
-		t.Fatalf("expected %d got %d", want, have)
-	}
-	if have := bc.storedHeaderCount; want != have {
-		t.Fatalf("expected %d got %d", want, have)
-	}
-	if !bc.CurrentBlockHash().Equals(startHash) {
-		t.Fatalf("expected current block hash to be %d got %s", startHash, bc.CurrentBlockHash())
-	}
+	assert.Equal(t, uint32(0), bc.BlockHeight())
+	assert.Equal(t, uint32(0), bc.HeaderHeight())
+	assert.Equal(t, uint32(1), bc.storedHeaderCount)
+	assert.Equal(t, startHash, bc.startHash)
 }
 
 func TestAddHeaders(t *testing.T) {
-	startHash, _ := util.Uint256DecodeString("996e37358dc369912041f966f8c5d8d3a8255ba5dcbd3447f8a82b55db869099")
-	bc := NewBlockchain(NewMemoryStore(), log.New(os.Stdout, "", 0), startHash)
-
-	h1 := &Header{BlockBase: BlockBase{Version: 0, Index: 1, Script: &transaction.Witness{}}}
-	h2 := &Header{BlockBase: BlockBase{Version: 0, Index: 2, Script: &transaction.Witness{}}}
-	h3 := &Header{BlockBase: BlockBase{Version: 0, Index: 3, Script: &transaction.Witness{}}}
+	bc := newTestBC()
+	h1 := newBlock(1).Header()
+	h2 := newBlock(2).Header()
+	h3 := newBlock(3).Header()
 
 	if err := bc.AddHeaders(h1, h2, h3); err != nil {
 		t.Fatal(err)
 	}
-	if want, have := h3.Index, bc.HeaderHeight(); want != have {
-		t.Fatalf("expected header height of %d got %d", want, have)
-	}
-	if want, have := uint32(0), bc.storedHeaderCount; want != have {
-		t.Fatalf("expected stored header count to be %d got %d", want, have)
-	}
+
+	assert.Equal(t, 0, bc.blockCache.Len())
+	assert.Equal(t, h3.Index, bc.HeaderHeight())
+	assert.Equal(t, uint32(1), bc.storedHeaderCount)
+	assert.Equal(t, uint32(0), bc.BlockHeight())
+	assert.Equal(t, h3.Hash(), bc.CurrentHeaderHash())
+}
+
+func TestAddBlock(t *testing.T) {
+	bc := newTestBC()
+	blocks := []*Block{
+		newBlock(1),
+		newBlock(2),
+		newBlock(3),
+	}
+
+	for i := 0; i < len(blocks); i++ {
+		if err := bc.AddBlock(blocks[i]); err != nil {
+			t.Fatal(err)
+		}
+	}
+
+	lastBlock := blocks[len(blocks)-1]
+	assert.Equal(t, 3, bc.blockCache.Len())
+	assert.Equal(t, lastBlock.Index, bc.HeaderHeight())
+	assert.Equal(t, lastBlock.Hash(), bc.CurrentHeaderHash())
+	assert.Equal(t, uint32(1), bc.storedHeaderCount)
+
+	if err := bc.persist(); err != nil {
+		t.Fatal(err)
+	}
+
+	assert.Equal(t, lastBlock.Index, bc.BlockHeight())
+	assert.Equal(t, lastBlock.Hash(), bc.CurrentHeaderHash())
+	assert.Equal(t, 0, bc.blockCache.Len())
+}
+
+func newTestBC() *Blockchain {
+	startHash, _ := util.Uint256DecodeString("a")
+	bc := NewBlockchain(NewMemoryStore(), startHash)
+	return bc
 }