TrueCloudLab/neoneo-go
7
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity

network: check height before requesting headers

Browse source 
Only request headers from the other peer if his height is bigger than
ours. Otherwise we routinely ask 0-height newcomers for some random headers
that they know nothing about.
This commit is contained in:
Roman Khimov 2019-11-29 11:46:01 +03:00
parent a730529b0c
commit 4d286dcfeb
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
pkg/network/server.go
View file

@ -284,6 +284,8 @@ func (s *Server) PeerCount() int {
// startProtocol starts a long running background loop that interacts // startProtocol starts a long running background loop that interacts
// every ProtoTickInterval with the peer. // every ProtoTickInterval with the peer.
func (s *Server) startProtocol(p Peer) { func (s *Server) startProtocol(p Peer) {
var err error
log.WithFields(log.Fields{ log.WithFields(log.Fields{
"addr": p.RemoteAddr(), "addr": p.RemoteAddr(),
"userAgent": string(p.Version().UserAgent), "userAgent": string(p.Version().UserAgent),
@ -292,10 +294,12 @@ func (s *Server) startProtocol(p Peer) {
}).Info("started protocol") }).Info("started protocol")
s.discovery.RegisterGoodAddr(p.PeerAddr().String()) s.discovery.RegisterGoodAddr(p.PeerAddr().String())
err := s.requestHeaders(p) if s.chain.HeaderHeight() < p.Version().StartHeight {
if err != nil { err = s.requestHeaders(p)
p.Disconnect(err) if err != nil {
return p.Disconnect(err)
return
}
} }
timer := time.NewTimer(s.ProtoTickInterval) timer := time.NewTimer(s.ProtoTickInterval)