TrueCloudLab/neoneo-go
7
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity

io: add type-specific read/write methods

Browse source 
This seriously improves the serialization/deserialization performance for
several reasons:
 * no time spent in `binary` reflection
 * no memory allocations being made on every read/write
 * uses fast ReadBytes everywhere it's appropriate

It also makes Fixed8 Serializable just for convenience.
This commit is contained in:
Roman Khimov 2019-12-12 18:52:23 +03:00
parent 89d7f6d26e
commit 54d888ba70
43 changed files with 441 additions and 205 deletions
Download patch file Download diff file Expand all files Collapse all files

10
pkg/smartcontract/contract_test.go
View file

@ -22,9 +22,7 @@ func TestCreateMultiSigRedeemScript(t *testing.T) {
}
br := io.NewBinReaderFromBuf(out)
var b uint8
br.ReadLE(&b)
assert.Equal(t, opcode.PUSH3, opcode.Opcode(b))
assert.Equal(t, opcode.PUSH3, opcode.Opcode(br.ReadByte()))
for i := 0; i < len(validators); i++ {
bb := br.ReadVarBytes()
@ -34,8 +32,6 @@ func TestCreateMultiSigRedeemScript(t *testing.T) {
assert.Equal(t, validators[i].Bytes(), bb)
}
br.ReadLE(&b)
assert.Equal(t, opcode.PUSH3, opcode.Opcode(b))
br.ReadLE(&b)
assert.Equal(t, opcode.CHECKMULTISIG, opcode.Opcode(b))
assert.Equal(t, opcode.PUSH3, opcode.Opcode(br.ReadByte()))
assert.Equal(t, opcode.CHECKMULTISIG, opcode.Opcode(br.ReadByte()))
}

4
pkg/smartcontract/param_context.go
View file

@ -80,12 +80,12 @@ func (pt ParamType) MarshalJSON() ([]byte, error) {
// EncodeBinary implements io.Serializable interface.
func (pt ParamType) EncodeBinary(w *io.BinWriter) {
w.WriteBytes([]byte{byte(pt)})
w.WriteByte(byte(pt))
}
// DecodeBinary implements io.Serializable interface.
func (pt *ParamType) DecodeBinary(r *io.BinReader) {
r.ReadLE(pt)
*pt = ParamType(r.ReadByte())
}
// NewParameter returns a Parameter with proper initialized Value