TrueCloudLab/neoneo-go
7
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity

core: avoid duplicates in GetScriptHashesForVerifyingClaim()

Browse source 
As they can break VerifyWitnesses().
This commit is contained in:
Roman Khimov 2019-10-11 12:21:09 +03:00
parent 35824728eb
commit 58d9b79fe3
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
pkg/core/blockchain.go
View file

@ -938,7 +938,8 @@ func (bc *Blockchain) GetTransactionResults(t *transaction.Transaction) []*trans
// GetScriptHashesForVerifyingClaim returns all ScriptHashes of Claim transaction // GetScriptHashesForVerifyingClaim returns all ScriptHashes of Claim transaction
// which has a different implementation from generic GetScriptHashesForVerifying. // which has a different implementation from generic GetScriptHashesForVerifying.
func (bc *Blockchain) GetScriptHashesForVerifyingClaim(t *transaction.Transaction) ([]util.Uint160, error) { func (bc *Blockchain) GetScriptHashesForVerifyingClaim(t *transaction.Transaction) ([]util.Uint160, error) {
hashes := make([]util.Uint160, 0) // Avoiding duplicates.
hashmap := make(map[util.Uint160]bool)
claim := t.Data.(*transaction.ClaimTX) claim := t.Data.(*transaction.ClaimTX)
clGroups := make(map[util.Uint256][]*transaction.Input) clGroups := make(map[util.Uint256][]*transaction.Input)
@ -954,10 +955,14 @@ func (bc *Blockchain) GetScriptHashesForVerifyingClaim(t *transaction.Transactio
if len(refTx.Outputs) <= int(input.PrevIndex) { if len(refTx.Outputs) <= int(input.PrevIndex) {
return nil, fmt.Errorf("wrong PrevIndex reference") return nil, fmt.Errorf("wrong PrevIndex reference")
} }
hashes = append(hashes, refTx.Outputs[input.PrevIndex].ScriptHash) hashmap[refTx.Outputs[input.PrevIndex].ScriptHash] = true
} }
} }
if len(hashes) > 0 { if len(hashmap) > 0 {
hashes := make([]util.Uint160, 0, len(hashmap))
for k := range hashmap {
hashes = append(hashes, k)
}
return hashes, nil return hashes, nil
} }
return nil, fmt.Errorf("no hashes found") return nil, fmt.Errorf("no hashes found")