From 59fdb69b9a7d0ac2c237b4029b3b8c92d93f7339 Mon Sep 17 00:00:00 2001
From: Anna Shaleva <anna@nspcc.ru>
Date: Mon, 7 Feb 2022 13:36:42 +0300
Subject: [PATCH] cli: add temp workaround to handle absolute log path for
 Windows

Fix #2269.
---
 cli/server/server.go      | 43 +++++++++++++++++++++++++++++++++++++++
 cli/server/server_test.go |  1 -
 2 files changed, 43 insertions(+), 1 deletion(-)

diff --git a/cli/server/server.go b/cli/server/server.go
index 19d3a407a..36bfd1c47 100644
--- a/cli/server/server.go
+++ b/cli/server/server.go
@@ -4,8 +4,10 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"net/url"
 	"os"
 	"os/signal"
+	"runtime"
 	"syscall"
 
 	"github.com/nspcc-dev/neo-go/cli/options"
@@ -29,6 +31,10 @@ import (
 	"go.uber.org/zap/zapcore"
 )
 
+// _winfileSinkRegistered denotes whether zap has registered
+// user-supplied factory for all sinks with `winfile`-prefixed scheme.
+var _winfileSinkRegistered bool
+
 // NewCommands returns 'node' command.
 func NewCommands() []cli.Command {
 	var cfgFlags = []cli.Flag{
@@ -145,6 +151,43 @@ func handleLoggingParams(ctx *cli.Context, cfg config.ApplicationConfiguration)
 			return nil, err
 		}
 
+		if runtime.GOOS == "windows" {
+			if !_winfileSinkRegistered {
+				// See https://github.com/uber-go/zap/issues/621.
+				err := zap.RegisterSink("winfile", func(u *url.URL) (zap.Sink, error) {
+					if u.User != nil {
+						return nil, fmt.Errorf("user and password not allowed with file URLs: got %v", u)
+					}
+					if u.Fragment != "" {
+						return nil, fmt.Errorf("fragments not allowed with file URLs: got %v", u)
+					}
+					if u.RawQuery != "" {
+						return nil, fmt.Errorf("query parameters not allowed with file URLs: got %v", u)
+					}
+					// Error messages are better if we check hostname and port separately.
+					if u.Port() != "" {
+						return nil, fmt.Errorf("ports not allowed with file URLs: got %v", u)
+					}
+					if hn := u.Hostname(); hn != "" && hn != "localhost" {
+						return nil, fmt.Errorf("file URLs must leave host empty or use localhost: got %v", u)
+					}
+					switch u.Path {
+					case "stdout":
+						return os.Stdout, nil
+					case "stderr":
+						return os.Stderr, nil
+					}
+					return os.OpenFile(u.Path[1:], // Remove leading slash left after url.Parse.
+						os.O_WRONLY|os.O_APPEND|os.O_CREATE, 0644)
+				})
+				if err != nil {
+					return nil, fmt.Errorf("failed to register windows-specific sinc: %w", err)
+				}
+				_winfileSinkRegistered = true
+			}
+			logPath = "winfile:///" + logPath
+		}
+
 		cc.OutputPaths = []string{logPath}
 	}
 
diff --git a/cli/server/server_test.go b/cli/server/server_test.go
index 7d0e8ebce..3165e7037 100644
--- a/cli/server/server_test.go
+++ b/cli/server/server_test.go
@@ -41,7 +41,6 @@ func TestGetConfigFromContext(t *testing.T) {
 }
 
 func TestHandleLoggingParams(t *testing.T) {
-	// This test is failing on Windows, see https://github.com/nspcc-dev/neo-go/issues/2269
 	d := t.TempDir()
 	testLog := filepath.Join(d, "file.log")