TrueCloudLab/neoneo-go
7
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #1471 from nspcc-dev/rpc-server-logging-improvement

Browse source 
server: don't always Sprintf params for logger
This commit is contained in:
Roman Khimov 2020-10-08 16:45:30 +03:00 committed by GitHub
commit 6025c13a6d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/rpc/request/params.go
View file

@ -1,5 +1,7 @@
package request
import "fmt"
type (
// Params represents the JSON-RPC params.
Params []Param
@ -23,3 +25,7 @@ func (p Params) ValueWithType(index int, valType paramType) *Param {
}
return nil
}
func (p Params) String() string {
return fmt.Sprintf("%v", []Param(p))
}

2
pkg/rpc/server/server.go
View file

@ -291,7 +291,7 @@ func (s *Server) handleRequest(req *request.In, sub *subscriber) response.Abstra
s.log.Debug("processing rpc request",
zap.String("method", req.Method),
zap.String("params", fmt.Sprintf("%v", reqParams)))
zap.Stringer("params", reqParams))
incCounter(req.Method)