From 6332d3604f9140c3bb875a49e6b28a8584ede7a1 Mon Sep 17 00:00:00 2001 From: Anna Shaleva Date: Wed, 2 Feb 2022 17:59:21 +0300 Subject: [PATCH] codecov: adjust codecov config and remove CircleCI coverage job Let's keep the only coverage job, so that CircleCI and GithubAction coverage do not conflict with each other. Also, let's do not require all other tests to pass to report the coverage. --- .circleci/config.yml | 20 -------------------- codecov.yml | 8 -------- 2 files changed, 28 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7613e5b97..7240ab665 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,6 +1,4 @@ version: 2.1 -orbs: - codecov: codecov/codecov@1.0.5 executors: go1_15: @@ -62,20 +60,6 @@ jobs: - gomod - run: go test -v -race ./... - test_cover: - working_directory: /go/src/github.com/nspcc-dev/neo-go - executor: go1_17 - environment: - CGO_ENABLED: 0 - steps: - - checkout - - run: git submodule sync - - run: git submodule update --init - - gomod - - run: go test -v ./... -coverprofile=coverage.txt -covermode=atomic -coverpkg=./pkg...,./cli/... - - codecov/upload: - file: coverage.txt - build_cli: working_directory: /go/src/github.com/nspcc-dev/neo-go executor: go1_17 @@ -125,10 +109,6 @@ workflows: filters: tags: only: v/[0-9]+\.[0-9]+\.[0-9]+/ - - test_cover: - filters: - tags: - only: v/[0-9]+\.[0-9]+\.[0-9]+/ - build_cli: filters: tags: diff --git a/codecov.yml b/codecov.yml index dff9fb2bf..828faad0d 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,11 +1,3 @@ codecov: require_ci_to_pass: no # We have several CI jobs that upload codecov results, # and sometimes some of them may fail, it's OK. -coverage: - status: - project: - default: # This can be anything, but it needs to exist as the name - if_ci_failed: error #success, failure, error, ignore - only_pulls: false -comment: - after_n_builds: 1