compiler: allow to slice struct field

It makes no sense to restrict to identifiers.
This commit is contained in:
Evgeniy Stratonikov 2021-11-30 12:55:51 +03:00
parent 33e37e60e5
commit 66a4245bef
2 changed files with 13 additions and 3 deletions

View file

@ -641,12 +641,12 @@ func (c *codegen) Visit(node ast.Node) ast.Visitor {
return nil return nil
case *ast.SliceExpr: case *ast.SliceExpr:
if isCompoundSlice(c.typeOf(n.X.(*ast.Ident)).Underlying()) { if isCompoundSlice(c.typeOf(n.X).Underlying()) {
c.prog.Err = errors.New("subslices are supported only for []byte") c.prog.Err = errors.New("subslices are supported only for []byte")
return nil return nil
} }
name := n.X.(*ast.Ident).Name
c.emitLoadVar("", name) ast.Walk(c, n.X)
if n.Low != nil { if n.Low != nil {
ast.Walk(c, n.Low) ast.Walk(c, n.Low)

View file

@ -432,6 +432,16 @@ func TestSubsliceCompound(t *testing.T) {
require.Error(t, err) require.Error(t, err)
} }
func TestSubsliceFromStructField(t *testing.T) {
src := `package foo
type pair struct { key, value []byte }
func Main() []byte {
p := pair{ []byte{1}, []byte{4, 8, 15, 16, 23, 42} }
return p.value[2:4]
}`
eval(t, src, []byte{15, 16})
}
func TestRemove(t *testing.T) { func TestRemove(t *testing.T) {
t.Run("Valid", func(t *testing.T) { t.Run("Valid", func(t *testing.T) {
src := `package foo src := `package foo