From 5fcae176b8f79f0caf8a80d9c0f02bb0c7f26fd7 Mon Sep 17 00:00:00 2001 From: Roman Khimov Date: Wed, 28 Feb 2024 12:07:42 +0300 Subject: [PATCH 1/2] workflows: add MacOS 14 runner for tests It's ARM-based, so it's a very nice combination. Signed-off-by: Roman Khimov --- .github/workflows/tests.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index e2db7bba7..bb47389a6 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -120,7 +120,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: [ubuntu-20.04, windows-2022, macos-12] + os: [ubuntu-20.04, windows-2022, macos-12, macos-14] go_versions: [ '1.19', '1.20', '1.21' ] exclude: # Only latest Go version for Windows and MacOS. @@ -132,6 +132,10 @@ jobs: go_versions: '1.19' - os: macos-12 go_versions: '1.20' + - os: macos-14 + go_versions: '1.19' + - os: macos-14 + go_versions: '1.20' # Exclude latest Go version for Ubuntu as Coverage uses it. - os: ubuntu-20.04 go_versions: '1.21' From 630bd29b8d7b878d2596eafde61dc6251e260c64 Mon Sep 17 00:00:00 2001 From: Roman Khimov Date: Wed, 28 Feb 2024 12:08:41 +0300 Subject: [PATCH 2/2] workflows: drop manual go mod downloads It's done automatically since like forever, these steps are useless. Signed-off-by: Roman Khimov --- .github/workflows/build.yml | 3 --- .github/workflows/tests.yml | 6 ------ 2 files changed, 9 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f1eb8c287..3567b1c89 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -56,9 +56,6 @@ jobs: go-version: '1.21' cache: true - - name: Update Go modules - run: go mod download -json - - name: Build CLI run: make build env: diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index bb47389a6..b475320e7 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -102,9 +102,6 @@ jobs: go-version: '1.21' cache: true - - name: Update Go modules - run: go mod download -json - - name: Write coverage profile run: go test -v ./... -coverprofile=./coverage.txt -covermode=atomic -coverpkg=./pkg...,./cli/... @@ -152,8 +149,5 @@ jobs: go-version: '${{ matrix.go_versions }}' cache: true - - name: Update Go modules - run: go mod download -json - - name: Run tests run: go test -v -race ./...