TrueCloudLab/neoneo-go
7
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity

io: rename Read/WriteBytes to Read/WriteB

Browse source 
go vet is not happy about them:
  pkg/io/binaryReader.go:92:21: method ReadByte() byte should have signature ReadByte() (byte, error)
  pkg/io/binaryWriter.go:75:21: method WriteByte(u8 byte) should have signature WriteByte(byte) error
This commit is contained in:
Roman Khimov 2019-12-12 20:17:50 +03:00
parent 0b14916d79
commit 8b3080b972
22 changed files with 70 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

6
pkg/io/binaryrw_test.go
View file

@ -128,12 +128,12 @@ func TestWriteByte(t *testing.T) {
bin = []byte{0xa5}
)
bw := NewBufBinWriter()
bw.WriteByte(val)
bw.WriteB(val)
assert.Nil(t, bw.Err)
wrotebin := bw.Bytes()
assert.Equal(t, wrotebin, bin)
br := NewBinReaderFromBuf(bin)
readval = br.ReadByte()
readval = br.ReadB()
assert.Nil(t, br.Err)
assert.Equal(t, val, readval)
}
@ -165,7 +165,7 @@ func TestReadLEErrors(t *testing.T) {
assert.Equal(t, uint32(0), br.ReadU32LE())
assert.Equal(t, uint16(0), br.ReadU16LE())
assert.Equal(t, uint16(0), br.ReadU16BE())
assert.Equal(t, byte(0), br.ReadByte())
assert.Equal(t, byte(0), br.ReadB())
assert.Equal(t, false, br.ReadBool())
assert.NotNil(t, br.Err)
}