core/config: make block and transaction verification configurable

Enable transaction verification for privnets and tests, testnet can't
successfuly verify block number 316711 with it enabled and mainnet stops at
105829.

config/config.go

@@ -49,6 +49,10 @@ type (
 		StandbyValidators       []string  `yaml:"StandbyValidators"`
 		SeedList                []string  `yaml:"SeedList"`
 		SystemFee               SystemFee `yaml:"SystemFee"`
+		// Whether to verify received blocks.
+		VerifyBlocks bool `yaml:"VerifyBlocks"`
+		// Whether to verify transactions in received blocks.
+		VerifyTransactions bool `yaml:"VerifyTransactions"`
 	}
 
 	// SystemFee fees related to system.

config/protocol.mainnet.yml

@@ -27,6 +27,8 @@ ProtocolConfiguration:
     IssueTransaction: 500
     PublishTransaction: 500
     RegisterTransaction: 10000
+  VerifyBlocks: true
+  VerifyTransactions: false
 
 ApplicationConfiguration:
   DBConfiguration:

config/protocol.privnet.docker.four.yml

@@ -15,6 +15,8 @@ ProtocolConfiguration:
     IssueTransaction: 500
     PublishTransaction: 500
     RegisterTransaction: 10000
+  VerifyBlocks: true
+  VerifyTransactions: true
 
 ApplicationConfiguration:
   DBConfiguration:

config/protocol.privnet.docker.one.yml

@@ -12,6 +12,8 @@ ProtocolConfiguration:
     IssueTransaction: 500
     PublishTransaction: 500
     RegisterTransaction: 10000
+  VerifyBlocks: true
+  VerifyTransactions: true
 
 ApplicationConfiguration:
   DBConfiguration:

config/protocol.privnet.docker.three.yml

@@ -12,6 +12,8 @@ ProtocolConfiguration:
     IssueTransaction: 500
     PublishTransaction: 500
     RegisterTransaction: 10000
+  VerifyBlocks: true
+  VerifyTransactions: true
 
 ApplicationConfiguration:
   DBConfiguration:

config/protocol.privnet.docker.two.yml

@@ -12,6 +12,8 @@ ProtocolConfiguration:
     IssueTransaction: 500
     PublishTransaction: 500
     RegisterTransaction: 10000
+  VerifyBlocks: true
+  VerifyTransactions: true
 
 ApplicationConfiguration:
   DBConfiguration:

config/protocol.privnet.yml

@@ -18,6 +18,8 @@ ProtocolConfiguration:
     IssueTransaction: 500
     PublishTransaction: 500
     RegisterTransaction: 10000
+  VerifyBlocks: true
+  VerifyTransactions: true
 
 ApplicationConfiguration:
   DBConfiguration:

config/protocol.testnet.yml

@@ -27,6 +27,8 @@ ProtocolConfiguration:
     IssueTransaction: 5
     PublishTransaction: 5
     RegisterTransaction: 100
+  VerifyBlocks: true
+  VerifyTransactions: false
 
 ApplicationConfiguration:
   DBConfiguration:

config/protocol.unit_testnet.yml

@@ -17,6 +17,8 @@ ProtocolConfiguration:
     IssueTransaction: 500
     PublishTransaction: 500
     RegisterTransaction: 10000
+  VerifyBlocks: true
+  VerifyTransactions: true
 
 ApplicationConfiguration:
   DBConfiguration:

pkg/core/blockchain.go

@@ -68,9 +68,6 @@ type Blockchain struct {
 	headersOp     chan headersOpFunc
 	headersOpDone chan struct{}
 
-	// Whether we will verify received blocks.
-	verifyBlocks bool
-
 	memPool MemPool
 }
 
@@ -85,7 +82,6 @@ func NewBlockchain(s storage.Store, cfg config.ProtocolConfiguration) (*Blockcha
 		memStore:      storage.NewMemoryStore(),
 		headersOp:     make(chan headersOpFunc),
 		headersOpDone: make(chan struct{}),
-		verifyBlocks:  false,
 		memPool:       NewMemPool(50000),
 	}
 
@@ -209,15 +205,17 @@ func (bc *Blockchain) AddBlock(block *Block) error {
 	if expectedHeight != block.Index {
 		return fmt.Errorf("expected block %d, but passed block %d", expectedHeight, block.Index)
 	}
-	if bc.verifyBlocks {
+	if bc.config.VerifyBlocks {
 		err := block.Verify(false)
 		if err != nil {
 			return fmt.Errorf("block %s is invalid: %s", block.Hash().ReverseString(), err)
 		}
-		for _, tx := range block.Transactions {
+		if bc.config.VerifyTransactions {
-			err := bc.VerifyTx(tx, block)
+			for _, tx := range block.Transactions {
-			if err != nil {
+				err := bc.VerifyTx(tx, block)
-				return fmt.Errorf("transaction %s failed to verify: %s", tx.Hash().ReverseString(), err)
+				if err != nil {
+					return fmt.Errorf("transaction %s failed to verify: %s", tx.Hash().ReverseString(), err)
+				}
 			}
 		}
 	}