From b31d39836af3d8f066330e45bfdc32e43ae61aa0 Mon Sep 17 00:00:00 2001
From: Roman Khimov <roman@nspcc.ru>
Date: Thu, 30 Nov 2023 15:55:17 +0300
Subject: [PATCH] native: test immediate contract availability

I had some reason to suspect something is wrong here (but it's all OK). Even
though this is kinda tested in TestDeployGetUpdateDestroyContract, it uses
internal APIs and with neotest we can ensure it work OK for a complete tx/block
environment. So, won't hurt having these tests as well.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
---
 pkg/core/native/management_neotest_test.go | 58 ++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/pkg/core/native/management_neotest_test.go b/pkg/core/native/management_neotest_test.go
index f34f30fb4..8c2f63d7f 100644
--- a/pkg/core/native/management_neotest_test.go
+++ b/pkg/core/native/management_neotest_test.go
@@ -1,6 +1,7 @@
 package native_test
 
 import (
+	"encoding/json"
 	"testing"
 
 	"github.com/nspcc-dev/neo-go/internal/basicchain"
@@ -9,10 +10,12 @@ import (
 	"github.com/nspcc-dev/neo-go/pkg/core/state"
 	"github.com/nspcc-dev/neo-go/pkg/neotest"
 	"github.com/nspcc-dev/neo-go/pkg/neotest/chain"
+	"github.com/nspcc-dev/neo-go/pkg/smartcontract"
 	"github.com/nspcc-dev/neo-go/pkg/smartcontract/manifest"
 	"github.com/nspcc-dev/neo-go/pkg/smartcontract/nef"
 	"github.com/nspcc-dev/neo-go/pkg/util"
 	"github.com/nspcc-dev/neo-go/pkg/vm/opcode"
+	"github.com/nspcc-dev/neo-go/pkg/vm/stackitem"
 	"github.com/stretchr/testify/require"
 )
 
@@ -74,3 +77,58 @@ func TestManagement_DeployUpdate_HFBasilisk(t *testing.T) {
 	ctr.Manifest.Name = "other name"
 	e.DeployContractCheckFAULT(t, ctr, nil, "invalid contract script: invalid offset 5 ip at 0")
 }
+
+func TestManagement_CallInTheSameBlock(t *testing.T) {
+	bc, acc := chain.NewSingle(t)
+
+	e := neotest.NewExecutor(t, bc, acc, acc)
+
+	ne, err := nef.NewFile([]byte{byte(opcode.PUSH1)})
+	require.NoError(t, err)
+
+	m := &manifest.Manifest{
+		Name: "ctr",
+		ABI: manifest.ABI{
+			Methods: []manifest.Method{
+				{
+					Name:   "main",
+					Offset: 0,
+				},
+			},
+		},
+	}
+
+	t.Run("same tx", func(t *testing.T) {
+		h := state.CreateContractHash(e.Validator.ScriptHash(), ne.Checksum, m.Name)
+
+		neb, err := ne.Bytes()
+		require.NoError(t, err)
+
+		rawManifest, err := json.Marshal(m)
+		require.NoError(t, err)
+
+		b := smartcontract.NewBuilder()
+		b.InvokeWithAssert(bc.ManagementContractHash(), "deploy", neb, rawManifest) // We need to drop the resulting contract and ASSERT does that.
+		b.InvokeWithAssert(bc.ManagementContractHash(), "hasMethod", h, "main", 0)
+		b.InvokeMethod(h, "main")
+
+		script, err := b.Script()
+		require.NoError(t, err)
+		txHash := e.InvokeScript(t, script, []neotest.Signer{e.Validator})
+		e.CheckHalt(t, txHash, stackitem.Make(1))
+	})
+	t.Run("next tx", func(t *testing.T) {
+		m.Name = "another contract"
+		h := state.CreateContractHash(e.Validator.ScriptHash(), ne.Checksum, m.Name)
+
+		txDeploy := e.NewDeployTx(t, e.Chain, &neotest.Contract{Hash: h, NEF: ne, Manifest: m}, nil)
+		txHasMethod := e.NewTx(t, []neotest.Signer{e.Validator}, bc.ManagementContractHash(), "hasMethod", h, "main", 0)
+
+		txCall := e.NewUnsignedTx(t, h, "main") // Test invocation doesn't give true GAS cost before deployment.
+		txCall = e.SignTx(t, txCall, 1_0000_0000, e.Validator)
+
+		e.AddNewBlock(t, txDeploy, txHasMethod, txCall)
+		e.CheckHalt(t, txHasMethod.Hash(), stackitem.Make(true))
+		e.CheckHalt(t, txCall.Hash(), stackitem.Make(1))
+	})
+}