TrueCloudLab/neoneo-go
7
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity

cli/wallet: use more secure way to read passwords

Browse source 
They were printed in plaintext, believe it or not. Also, `ssh/terminal` does
some proper magic to really read something from the terminal.
This commit is contained in:
Roman Khimov 2019-12-03 20:04:52 +03:00
parent e002d7b40c
commit c8aa061421
3 changed files with 28 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
cli/wallet/wallet.go
View file

@ -6,9 +6,11 @@ import (
"fmt"
"os"
"strings"
"syscall"
"github.com/CityOfZion/neo-go/pkg/wallet"
"github.com/urfave/cli"
"golang.org/x/crypto/ssh/terminal"
)
var (
@ -90,9 +92,9 @@ func createAccount(ctx *cli.Context, wall *wallet.Wallet) error {
fmt.Print("Enter the name of the account > ")
rawName, _ = buf.ReadBytes('\n')
fmt.Print("Enter passphrase > ")
rawPhrase, _ = buf.ReadBytes('\n')
fmt.Print("Confirm passphrase > ")
rawPhraseCheck, _ = buf.ReadBytes('\n')
rawPhrase, _ = terminal.ReadPassword(int(syscall.Stdin))
fmt.Print("\nConfirm passphrase > ")
rawPhraseCheck, _ = terminal.ReadPassword(int(syscall.Stdin))
// Clean data
var (