TrueCloudLab/neoneo-go
7
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity

server: don't always Sprintf params for logger

Browse source 
Add Stringer to Params, if we're not printing Debug messages (which usually is
the case), it won't be called at all. Micro-optimization.
This commit is contained in:
Roman Khimov 2020-10-08 16:29:30 +03:00
parent 70e9e329cd
commit c8ba155d47
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/rpc/request/params.go
View file

@ -1,5 +1,7 @@
package request package request
import "fmt"
type ( type (
// Params represents the JSON-RPC params. // Params represents the JSON-RPC params.
Params []Param Params []Param
@ -23,3 +25,7 @@ func (p Params) ValueWithType(index int, valType paramType) *Param {
} }
return nil return nil
} }
func (p Params) String() string {
return fmt.Sprintf("%v", []Param(p))
}

2
pkg/rpc/server/server.go
View file

@ -291,7 +291,7 @@ func (s *Server) handleRequest(req *request.In, sub *subscriber) response.Abstra
s.log.Debug("processing rpc request", s.log.Debug("processing rpc request",
zap.String("method", req.Method), zap.String("method", req.Method),
zap.String("params", fmt.Sprintf("%v", reqParams))) zap.Stringer("params", reqParams))
incCounter(req.Method) incCounter(req.Method)