core: add NewTransactionFromBytes method to Transaction

Added `NewTransactionFromBytes(b []byte)` method to
transaction.Transaction in order to avoid code duplication.
This commit is contained in:
Anna Shaleva 2020-04-13 12:02:18 +03:00
parent 5a22651e36
commit d1f92a585b
4 changed files with 18 additions and 12 deletions

View file

@ -931,10 +931,8 @@ func (s *Server) sendrawtransaction(reqParams request.Params) (interface{}, erro
} else if byteTx, err := reqParams[0].GetBytesHex(); err != nil {
return nil, response.ErrInvalidParams
} else {
r := io.NewBinReaderFromBuf(byteTx)
tx := &transaction.Transaction{}
tx.DecodeBinary(r)
if r.Err != nil {
tx, err := transaction.NewTransactionFromBytes(byteTx)
if err != nil {
return nil, response.ErrInvalidParams
}
relayReason := s.coreServer.RelayTxn(tx)