From d2bc4473ce9b00aae1a2660c126f090ca2acafa1 Mon Sep 17 00:00:00 2001 From: AnnaShaleva Date: Thu, 17 Mar 2022 13:33:52 +0300 Subject: [PATCH] circleci: upgrade golangci linter version The old one isn't able to properly work with go > 1.15. However, the updated version doesn't work with go 1.18, see https://github.com/golangci/golangci-lint/issues/2649. So let's keep go1_17 runner with the latest golangci by now. --- .circleci/config.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index be6323488..2703ce10c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -28,14 +28,15 @@ commands: jobs: lint: working_directory: /home/circleci/go/src/github.com/nspcc-dev/neo-go - executor: go1_18 + # TODO: temp workaround, need to upgrade to go1_18 after https://github.com/golangci/golangci-lint/issues/2649 is resolved. + executor: go1_17 steps: - checkout - gomod - run: name: go-lint command: | - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.42.1 + curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.44.2 make lint test_1_16: