TrueCloudLab/neoneo-go
7
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity

compiler: emit bytecode for unused exported functions

Browse source 
Exported functions should always be present in byte-code.
This will be needed later when arbitrary method calls are allowed.
This commit is contained in:
Evgenii Stratonikov 2020-07-23 17:40:49 +03:00
parent 54d7882acf
commit e87eba51f9
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/compiler/analysis.go
View file

@ -113,10 +113,11 @@ func lastStmtIsReturn(decl *ast.FuncDecl) (b bool) {
return false return false
} }
func analyzeFuncUsage(pkgs map[*types.Package]*loader.PackageInfo) funcUsage { func analyzeFuncUsage(mainPkg *loader.PackageInfo, pkgs map[*types.Package]*loader.PackageInfo) funcUsage {
usage := funcUsage{} usage := funcUsage{}
for _, pkg := range pkgs { for _, pkg := range pkgs {
isMain := pkg == mainPkg
for _, f := range pkg.Files { for _, f := range pkg.Files {
ast.Inspect(f, func(node ast.Node) bool { ast.Inspect(f, func(node ast.Node) bool {
switch n := node.(type) { switch n := node.(type) {
@ -127,6 +128,11 @@ func analyzeFuncUsage(pkgs map[*types.Package]*loader.PackageInfo) funcUsage {
case *ast.SelectorExpr: case *ast.SelectorExpr:
usage[t.Sel.Name] = true usage[t.Sel.Name] = true
} }
case *ast.FuncDecl:
// exported functions are always assumed to be used
if isMain && n.Name.IsExported() {
usage[n.Name.Name] = true
}
} }
return true return true
}) })

2
pkg/compiler/codegen.go
View file

@ -1426,7 +1426,7 @@ func (c *codegen) compile(info *buildInfo, pkg *loader.PackageInfo) error {
return c.prog.Err return c.prog.Err
} }
funUsage := analyzeFuncUsage(info.program.AllPackages) funUsage := analyzeFuncUsage(pkg, info.program.AllPackages)
// Bring all imported functions into scope. // Bring all imported functions into scope.
for _, pkg := range info.program.AllPackages { for _, pkg := range info.program.AllPackages {