TrueCloudLab/neoneo-go
7
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity

core: improve error checks in TestNotify

Browse source 
Ensure that the error returned from runtime.Notify is exactly the error
that was expected.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This commit is contained in:
Anna Shaleva 2023-08-18 16:38:40 +03:00
parent 2872c1c668
commit ed2c4b0319
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
pkg/core/interop/runtime/ext_test.go
View file

@ -5,6 +5,7 @@ import (
"math"
"math/big"
"path/filepath"
"strings"
"testing"
"github.com/nspcc-dev/neo-go/internal/contracts"
@ -643,26 +644,34 @@ func TestNotify(t *testing.T) {
}
t.Run("big name", func(t *testing.T) {
ic := newIC(string(make([]byte, runtime.MaxEventNameLen+1)), stackitem.NewArray([]stackitem.Item{stackitem.Null{}}))
require.Error(t, runtime.Notify(ic))
err := runtime.Notify(ic)
require.Error(t, err)
require.True(t, strings.Contains(err.Error(), "event name must be less than 32"), err)
})
t.Run("dynamic script", func(t *testing.T) {
ic := newIC("some", stackitem.Null{})
ic.VM.LoadScriptWithHash([]byte{1}, random.Uint160(), callflag.NoneFlag)
ic.VM.Estack().PushVal(stackitem.NewArray([]stackitem.Item{stackitem.Make(42)}))
ic.VM.Estack().PushVal("event")
require.Error(t, runtime.Notify(ic))
err := runtime.Notify(ic)
require.Error(t, err)
require.True(t, strings.Contains(err.Error(), "notifications are not allowed in dynamic scripts"), err)
})
t.Run("recursive struct", func(t *testing.T) {
arr := stackitem.NewArray([]stackitem.Item{stackitem.Null{}})
arr.Append(arr)
ic := newIC("event", stackitem.NewArray([]stackitem.Item{arr})) // upper array is needed to match manifest event signature.
require.Error(t, runtime.Notify(ic))
err := runtime.Notify(ic)
require.Error(t, err)
require.True(t, strings.Contains(err.Error(), "bad notification: recursive item"), err)
})
t.Run("big notification", func(t *testing.T) {
bs := stackitem.NewByteArray(make([]byte, runtime.MaxNotificationSize+1))
arr := stackitem.NewArray([]stackitem.Item{bs})
ic := newIC("event", arr)
require.Error(t, runtime.Notify(ic))
err := runtime.Notify(ic)
require.Error(t, err)
require.True(t, strings.Contains(err.Error(), "notification size shouldn't exceed 1024"), err)
})
t.Run("good", func(t *testing.T) {
arr := stackitem.NewArray([]stackitem.Item{stackitem.Make(42)})