From ed358b4c4ceeace1fd225e41a0ae1b967279499d Mon Sep 17 00:00:00 2001 From: Roman Khimov Date: Tue, 6 Apr 2021 22:22:34 +0300 Subject: [PATCH] native: expose MinimumResponseGas, add specific error for it --- pkg/core/native/oracle.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pkg/core/native/oracle.go b/pkg/core/native/oracle.go index 9bc81cd18..abd99fbf5 100644 --- a/pkg/core/native/oracle.go +++ b/pkg/core/native/oracle.go @@ -61,6 +61,9 @@ const ( // DefaultOracleRequestPrice is default amount GAS needed for oracle request. DefaultOracleRequestPrice = 5000_0000 + + // MinimumResponseGas is the minimum response fee permitted for request. + MinimumResponseGas = 10_000_000 ) var ( @@ -74,6 +77,7 @@ var ( var ( ErrBigArgument = errors.New("some of the arguments are invalid") ErrInvalidWitness = errors.New("witness check failed") + ErrLowResponseGas = errors.New("not enough gas for response") ErrNotEnoughGas = errors.New("gas limit exceeded") ErrRequestNotFound = errors.New("oracle request not found") ErrResponseNotFound = errors.New("oracle response not found") @@ -323,9 +327,12 @@ func (o *Oracle) request(ic *interop.Context, args []stackitem.Item) stackitem.I // RequestInternal processes oracle request. func (o *Oracle) RequestInternal(ic *interop.Context, url string, filter *string, cb string, userData stackitem.Item, gas *big.Int) error { - if len(url) > maxURLLength || (filter != nil && len(*filter) > maxFilterLength) || len(cb) > maxCallbackLength || gas.Uint64() < 1000_0000 { + if len(url) > maxURLLength || (filter != nil && len(*filter) > maxFilterLength) || len(cb) > maxCallbackLength { return ErrBigArgument } + if gas.Uint64() < MinimumResponseGas { + return ErrLowResponseGas + } if strings.HasPrefix(cb, "_") { return errors.New("disallowed callback method (starts with '_')") }