Merge pull request #2204 from nspcc-dev/compiler-underscore

compiler: allow to use multiple underscores in func arguments
This commit is contained in:
Roman Khimov 2021-10-11 17:08:36 +03:00 committed by GitHub
commit fa2ca3f25a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 0 deletions

View file

@ -313,3 +313,14 @@ func TestJumpOptimize(t *testing.T) {
require.Equal(t, b[mi.Range.End], byte(opcode.RET))
}
}
func TestFunctionUnusedParameters(t *testing.T) {
src := `package foo
func add13(a int, _ int, _1 int, _ int) int {
return a + _1
}
func Main() int {
return add13(1, 10, 100, 1000)
}`
eval(t, src, big.NewInt(101))
}

View file

@ -2,6 +2,7 @@ package compiler
import (
"go/ast"
"strconv"
)
type varScope struct {
@ -70,6 +71,12 @@ func (c *varScope) newVariable(t varType, name string) int {
case varLocal:
return c.newLocal(name)
case varArgument:
if name == "_" {
// See #2204. This name won't actually be referenced.
// This approach simplifies argument allocation and
// makes debugging easier.
name = "%_" + strconv.FormatUint(uint64(len(c.arguments)), 10)
}
_, ok := c.arguments[name]
if ok {
panic("argument is already allocated")