TrueCloudLab/neoneo-go
7
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity

network: prevent broadcast queue starving, share time with p2p

Browse source 
Blocked broadcast queue of one peer may affect broadcasting capabilities of
the server, so prevent total blocking of it by p2p queue.
This commit is contained in:
Roman Khimov 2020-01-29 11:36:26 +03:00
parent b2c4587dad
commit fdbaac7a30
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
pkg/network/tcp_peer.go
View file

@ -167,6 +167,11 @@ func (p *TCPPeer) handleConn() {
// send queues.
func (p *TCPPeer) handleQueues() {
var err error
// p2psend queue shares its time with send queue in around
// ((p2pSkipDivisor - 1) * 2 + 1)/1 ratio, ratio because the third
// select can still choose p2psend over send.
var p2pSkipCounter uint32
const p2pSkipDivisor = 4
for {
var msg []byte
@ -179,7 +184,8 @@ func (p *TCPPeer) handleQueues() {
default:
}
if msg == nil {
// Skip this select every p2pSkipDivisor iteration.
if msg == nil && p2pSkipCounter%p2pSkipDivisor != 0 {
// Then look at the p2p queue.
select {
case <-p.done:
@ -204,6 +210,7 @@ func (p *TCPPeer) handleQueues() {
if err != nil {
break
}
p2pSkipCounter++
}
p.Disconnect(err)
}