TrueCloudLab/neoneo-go
7
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity

rpcclient: Fix ws-reader hang on sending a response #1

Merged
fyrchik merged 1 commit from aarifullin/neoneo-go:fix/wsreader_hang into support/v0.106-mtls 2024-07-26 10:59:10 +00:00
Conversation 0 Commits 1 Files changed 1 +7 -1
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/rpcclient/wsclient.go
View file

@ -601,7 +601,13 @@ readloop:
connCloseErr = fmt.Errorf("unknown response channel for response %d", id)
break readloop // Unknown response (unexpected response ID).
}
ch <- &rr.Response
select {
case <-c.writerDone:
break readloop
case <-c.shutdown:
break readloop
case ch <- &rr.Response:
fyrchik commented 2024-07-26 09:19:42 +00:00
Outdated
Review
Copy link

This will overwrite the previous connection error.
I think if any of this is done, the connection error already exists and is descriptive.

This will overwrite the previous connection error. I think if any of this is done, the connection error already exists and is descriptive.
aarifullin commented 2024-07-26 09:37:13 +00:00
Outdated
Review
Copy link

Removed

Removed
}
} else {
// Malformed response, neither valid request, nor valid response.
connCloseErr = fmt.Errorf("malformed response")