TrueCloudLab/policy-engine
20
0
Fork 11
generated from TrueCloudLab/basic
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Add policy validation checks #57

Merged
dkirillov merged 1 commit from mbiryukova/policy-engine:feature/add_policy_validation_checks into master 2024-03-11 13:22:17 +00:00
Conversation 0 Commits 1 Files changed 3 +64 -3
mbiryukova commented 2024-03-11 11:15:56 +00:00
Member
Copy link

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-03-11 11:15:56 +00:00
mbiryukova force-pushed feature/add_policy_validation_checks from 5a2b000530 to dccdb3621c 2024-03-11 11:20:10 +00:00 Compare
mbiryukova changed title from [#xx] Add policy validation checks to [#57] Add policy validation checks 2024-03-11 11:23:36 +00:00
mbiryukova requested review from storage-core-committers 2024-03-11 11:24:55 +00:00
mbiryukova requested review from storage-core-developers 2024-03-11 11:24:56 +00:00
mbiryukova requested review from storage-services-developers 2024-03-11 11:24:56 +00:00
mbiryukova requested review from storage-services-committers 2024-03-11 11:24:57 +00:00
dstepanov-yadro approved these changes 2024-03-11 12:43:06 +00:00
acid-ant changed title from [#57] Add policy validation checks to Add policy validation checks 2024-03-11 12:53:29 +00:00
acid-ant approved these changes 2024-03-11 12:59:24 +00:00
dkirillov reviewed 2024-03-11 13:06:57 +00:00
iam/policy.go Outdated
@ -226,3 +232,4 @@
return errors.New("'Statement' is missing")
}
sids := make(map[string]struct{})
dkirillov commented 2024-03-11 13:06:57 +00:00
Member
Copy link

It's better to use make(map[string]struct{}, len(p.Statement)

It's better to use `make(map[string]struct{}, len(p.Statement)`
dkirillov marked this conversation as resolved
dkirillov approved these changes 2024-03-11 13:10:27 +00:00
mbiryukova force-pushed feature/add_policy_validation_checks from dccdb3621c to 9040e48504 2024-03-11 13:14:24 +00:00 Compare
dkirillov approved these changes 2024-03-11 13:21:21 +00:00
dkirillov merged commit 9040e48504 into master 2024-03-11 13:22:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
dkirillov
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#57
No description provided.
Delete branch "mbiryukova/policy-engine:feature/add_policy_validation_checks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?