TrueCloudLab/policy-engine
20
0
Fork 11
generated from TrueCloudLab/basic
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity Actions

engine: Add user and group targets #64

Merged
fyrchik merged 1 commit from fyrchik/policy-engine:fix-user-chains into master 2024-04-12 13:49:57 +00:00
Conversation 2 Commits 1 Files changed 3 +55 -7
fyrchik commented 2024-04-09 15:11:17 +00:00
Owner
Copy link

Policies can be attached to a specific user. One way to handle this is to encode user in the rule condition. This is far from optimal, as it scales badly with the increase in the number of users.

Another option is to store user rules separately: the goal of this PR.

On a side-note, may be the best way to handle this is to make RequestTarget an interface which can return a list of targets in the order the are applied. With this, no changes would've been needed to support separate user/group rules.

Policies can be attached to a specific user. One way to handle this is to encode user in the rule condition. This is far from optimal, as it scales badly with the increase in the number of users. Another option is to store user rules separately: the goal of this PR. On a side-note, may be the best way to handle this is to make `RequestTarget` an interface which can return a list of targets in the order the are applied. With this, no changes would've been needed to support separate user/group rules.
fyrchik force-pushed fix-user-chains from 64c47aa1d0 to 6bdab34caa 2024-04-09 15:19:49 +00:00 Compare
fyrchik requested review from alexvanin 2024-04-10 12:47:39 +00:00
fyrchik requested review from dkirillov 2024-04-10 12:47:40 +00:00
fyrchik requested review from aarifullin 2024-04-10 12:47:49 +00:00
fyrchik requested review from storage-core-committers 2024-04-10 12:47:50 +00:00
fyrchik requested review from storage-core-developers 2024-04-10 12:47:50 +00:00
fyrchik requested review from storage-services-committers 2024-04-10 12:47:50 +00:00
fyrchik requested review from storage-services-developers 2024-04-10 12:47:51 +00:00
dkirillov approved these changes 2024-04-11 06:58:40 +00:00
alexvanin commented 2024-04-11 08:15:45 +00:00
Owner
Copy link

We should update pkg/engine/inmemory and pkg/morph/policy packages to support new targets.

We should update `pkg/engine/inmemory` and `pkg/morph/policy` packages to support new targets.
fyrchik force-pushed fix-user-chains from 6bdab34caa to 0cd259dd3f 2024-04-11 10:41:59 +00:00 Compare
fyrchik commented 2024-04-11 10:42:03 +00:00
Author
Owner
Copy link

@alexvanin fixed

@alexvanin fixed
alexvanin approved these changes 2024-04-11 10:43:10 +00:00
fyrchik force-pushed fix-user-chains from 0cd259dd3f to 6a495fccaa 2024-04-11 12:06:19 +00:00 Compare
fyrchik force-pushed fix-user-chains from 6a495fccaa to 0e69e48511 2024-04-12 13:07:42 +00:00 Compare
fyrchik changed title from WIP: engine: Add user and group targets to engine: Add user and group targets 2024-04-12 13:07:57 +00:00
alexvanin approved these changes 2024-04-12 13:13:01 +00:00
acid-ant approved these changes 2024-04-12 13:20:09 +00:00
dkirillov approved these changes 2024-04-12 13:42:40 +00:00
fyrchik merged commit 0e69e48511 into master 2024-04-12 13:49:57 +00:00
fyrchik deleted branch fix-user-chains 2024-04-12 16:31:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
alexvanin
acid-ant
dkirillov
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#64
No description provided.
Delete branch "fyrchik/policy-engine:fix-user-chains"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?