Revise request interface #8

Closed
opened 2023-10-26 14:10:45 +00:00 by fyrchik · 3 comments
Owner

It is an interface in an initial implementation.
After doing some prototyping (cc @aarifullin), we might want to change it.
Note, that it should be possible to use from both s3 and gRPC, and we wouldn't like to depend on the FrostFS API here

It is an interface in an initial implementation. After doing some prototyping (cc @aarifullin), we might want to change it. Note, that it should be possible to use from both s3 and gRPC, and we wouldn't like to depend on the FrostFS API here
fyrchik added the
refactoring
label 2023-10-26 14:12:54 +00:00

Should replace Property(string) string with Property(string) (string, bool): it is necessary to distinguish between the case when the property is not set, and the property is set by an empty string.

Should replace `Property(string) string` with `Property(string) (string, bool)`: it is necessary to distinguish between the case when the property is not set, and the property is set by an empty string.
Member

Should replace Property(string) string with Property(string) (string, bool): it is necessary to distinguish between the case when the property is not set, and the property is set by an empty string.

Would not be simpler to return *string in this case?

> Should replace `Property(string) string` with `Property(string) (string, bool)`: it is necessary to distinguish between the case when the property is not set, and the property is set by an empty string. Would not be simpler to return `*string` in this case?
Author
Owner

This task was for needed QoL changes after using this library in node.
All issues were fixed, the interface seems suitable.

This task was for needed QoL changes after using this library in node. All issues were fixed, the interface seems suitable.
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#8
No description provided.