TrueCloudLab/policy-engine
18
0
Fork 10
generated from TrueCloudLab/basic
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions

engine: Fix ruleFound return value #90

Merged
alexvanin merged 1 commit from fyrchik/policy-engine:refactor-rulefound into master 2024-08-21 07:20:39 +00:00
Conversation 0 Commits 1 Files changed 2 +47 -6
fyrchik commented 2024-08-20 15:55:46 +00:00
Owner
Copy link

It can be false if the first targets allows operation and the last one
returns NoRuleFound.

Found by @mbiryukova.
Introduced in #86.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

It can be false if the first targets allows operation and the last one returns NoRuleFound. Found by @mbiryukova. Introduced in #86. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added 1 commit 2024-08-20 15:55:57 +00:00
engine: Fix ruleFound return value
Some checks failed
Tests and linters / Tests (1.20) (pull_request) Failing after 3m45s
Details
DCO action / DCO (pull_request) Failing after 4m0s
Details
Tests and linters / Tests (1.21) (pull_request) Failing after 3m55s
Details
Tests and linters / Tests with -race (pull_request) Failing after 3m52s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m40s
Details
Tests and linters / Lint (pull_request) Successful in 4m48s
Details
39e1765fc5 
It can be false if the first targets allows operation and the last one
returns NoRuleFound.

Found by @mbiryukova .

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from mbiryukova 2024-08-20 15:56:08 +00:00
fyrchik force-pushed refactor-rulefound from 39e1765fc5 to 3df9afdb30 2024-08-20 15:57:18 +00:00 Compare
fyrchik requested review from storage-core-committers 2024-08-20 15:57:34 +00:00
fyrchik requested review from storage-core-developers 2024-08-20 15:57:38 +00:00
fyrchik force-pushed refactor-rulefound from 3df9afdb30 to a4ab0dcee9 2024-08-20 15:58:07 +00:00 Compare
fyrchik force-pushed refactor-rulefound from a4ab0dcee9 to ce5a5e6f59 2024-08-20 15:58:28 +00:00 Compare
fyrchik force-pushed refactor-rulefound from ce5a5e6f59 to 59a59e3cf7 2024-08-20 16:06:28 +00:00 Compare
fyrchik force-pushed refactor-rulefound from 59a59e3cf7 to bb77b1cccd 2024-08-20 17:22:00 +00:00 Compare
dstepanov-yadro approved these changes 2024-08-21 06:30:08 +00:00
dkirillov approved these changes 2024-08-21 06:39:21 +00:00
mbiryukova approved these changes 2024-08-21 07:01:19 +00:00
alexvanin approved these changes 2024-08-21 07:20:35 +00:00
alexvanin merged commit a1386f6d25 into master 2024-08-21 07:20:39 +00:00
alexvanin deleted branch refactor-rulefound 2024-08-21 07:20:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
dkirillov
mbiryukova
alexvanin
TrueCloudLab/storage-core-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#90
No description provided.
Delete branch "fyrchik/policy-engine:refactor-rulefound"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?