TrueCloudLab/policy-engine
21
0
Fork 11
generated from TrueCloudLab/basic
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity Actions

Add CODEOWNERS #96

Open
potyarkin wants to merge 1 commit from potyarkin/policy-engine:feature/add-codeowners into master
pull from: potyarkin/policy-engine:feature/add-codeowners
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 1 +3
potyarkin commented 2024-12-10 15:40:13 +00:00
Member
Copy link

CODEOWNERS file specifies reviewers which will be automatically added to each PR.

Forgejo uses a bespoke CODEOWNERS parser. It differs from most other tools:

  • Filepaths are matched using Golang regex library instead of simple fileglobs
  • All matching lines are active instead of only the first one
  • There is no support for defining ad-hoc groups, only org teams are supported (@TrueCloudLab/team-name)

This PR is a part of multirepo cleanup effort: TrueCloudLab/frostfs-infra#90

CODEOWNERS file specifies reviewers which will be automatically added to each PR. Forgejo uses a bespoke CODEOWNERS parser. It differs from most other tools: - Filepaths are matched using Golang regex library instead of simple fileglobs - All matching lines are active instead of only the first one - There is no support for defining ad-hoc groups, only org teams are supported (@TrueCloudLab/team-name) This PR is a part of multirepo cleanup effort: https://git.frostfs.info/TrueCloudLab/frostfs-infra/issues/90
potyarkin added 1 commit 2024-12-10 15:40:14 +00:00
[#] Add CODEOWNERS
Some checks failed
Tests and linters / Tests with -race (pull_request) Successful in 3m16s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m31s
Details
Tests and linters / Tests (pull_request) Successful in 7m18s
Details
DCO action / DCO (pull_request) Failing after 7m19s
Details
Tests and linters / Lint (pull_request) Successful in 8m32s
Details
4600b2f56b 
Signed-off-by: Vitaliy Potyarkin <v.potyarkin@yadro.com>
potyarkin force-pushed feature/add-codeowners from 4600b2f56b to 9c98b05066 2024-12-10 15:57:07 +00:00 Compare
potyarkin changed title from WIP: Add CODEOWNERS to Add CODEOWNERS 2024-12-10 15:57:14 +00:00
fyrchik approved these changes 2024-12-11 03:25:33 +00:00
All checks were successful
Tests and linters / Staticcheck (pull_request) Successful in 4m18s
Details
Tests and linters / Lint (pull_request) Successful in 5m3s
Details
DCO action / DCO (pull_request) Successful in 6m3s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m45s
Details
Tests and linters / Tests (pull_request) Successful in 1m47s
Details
This pull request doesn't have enough approvals yet. 1 of 2 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feature/add-codeowners:potyarkin-feature/add-codeowners
git checkout potyarkin-feature/add-codeowners
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/policy-engine#96
No description provided.
Delete branch "potyarkin/policy-engine:feature/add-codeowners"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?