TrueCloudLab/rclone
16
0
Fork 4
Code Issues 4 Pull requests 2 Projects Releases 1 Packages Wiki Activity Actions

fichier: parse api error codes and them accordingly

Browse source
This commit is contained in:
buengese 2022-06-18 01:39:44 +02:00 • committed by Sebastian Bünger
parent 36add0afbf
commit 21c746a56c
1 changed files with 31 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
backend/fichier/api.go
View file

@ -28,25 +28,44 @@ var retryErrorCodes = []int{
509, // Bandwidth Limit Exceeded 509, // Bandwidth Limit Exceeded
} }
var errorRegex = regexp.MustCompile(`#\d{1,3}`)
func parseFichierError(err error) int {
matches := errorRegex.FindStringSubmatch(err.Error())
if len(matches) == 0 {
return 0
}
code, err := strconv.Atoi(matches[0])
if err != nil {
fs.Debugf(nil, "failed parsing fichier error: %v", err)
return 0
}
return code
}
// shouldRetry returns a boolean as to whether this resp and err // shouldRetry returns a boolean as to whether this resp and err
// deserve to be retried. It returns the err as a convenience // deserve to be retried. It returns the err as a convenience
func shouldRetry(ctx context.Context, resp *http.Response, err error) (bool, error) { func shouldRetry(ctx context.Context, resp *http.Response, err error) (bool, error) {
if fserrors.ContextError(ctx, &err) { if fserrors.ContextError(ctx, &err) {
return false, err return false, err
} }
// Detect this error which the integration tests provoke // 1Fichier uses HTTP error code 403 (Forbidden) for all kinds of errors with
// error HTTP error 403 (403 Forbidden) returned body: "{\"message\":\"Flood detected: IP Locked #374\",\"status\":\"KO\"}" // responses looking like this: "{\"message\":\"Flood detected: IP Locked #374\",\"status\":\"KO\"}"
// //
// https://1fichier.com/api.html // We attempt to parse the actual 1Fichier error code from this body and handle it accordingly
// // Most importantly #374 (Flood detected: IP locked) which the integration tests provoke
// file/ls.cgi is limited : // The list below is far from complete and should be expanded if we see any more error codes.
// if err != nil {
// Warning (can be changed in case of abuses) : switch parseFichierError(err) {
// List all files of the account is limited to 1 request per hour. case 93:
// List folders is limited to 5 000 results and 1 request per folder per 30s. return false, err // No such user
if err != nil && strings.Contains(err.Error(), "Flood detected") { case 186:
fs.Debugf(nil, "Sleeping for 30 seconds due to: %v", err) return false, err // IP blocked?
time.Sleep(30 * time.Second) case 374:
fs.Debugf(nil, "Sleeping for 30 seconds due to: %v", err)
time.Sleep(30 * time.Second)
default:
}
} }
return fserrors.ShouldRetry(err) || fserrors.ShouldRetryHTTP(resp, retryErrorCodes), err return fserrors.ShouldRetry(err) || fserrors.ShouldRetryHTTP(resp, retryErrorCodes), err
} }