TrueCloudLab/rclone
16
0
Fork 2
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

operations: don't buffer when a backend implements OpenWriterAt

Browse source 
In this case we don't seek on errors so no need for seeking.
This commit is contained in:
Nick Craig-Wood 2023-08-24 17:23:07 +01:00
parent bc986b44b2
commit 2f424ceecf
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
fs/operations/multithread.go
View file

@ -135,12 +135,15 @@ func calculateNumChunks(size int64, chunkSize int64) int {
func multiThreadCopy(ctx context.Context, f fs.Fs, remote string, src fs.Object, streams int, tr *accounting.Transfer) (newDst fs.Object, err error) { func multiThreadCopy(ctx context.Context, f fs.Fs, remote string, src fs.Object, streams int, tr *accounting.Transfer) (newDst fs.Object, err error) {
openChunkWriter := f.Features().OpenChunkWriter openChunkWriter := f.Features().OpenChunkWriter
ci := fs.GetConfig(ctx) ci := fs.GetConfig(ctx)
noseek := false
if openChunkWriter == nil { if openChunkWriter == nil {
openWriterAt := f.Features().OpenWriterAt openWriterAt := f.Features().OpenWriterAt
if openWriterAt == nil { if openWriterAt == nil {
return nil, errors.New("multi-thread copy: neither OpenChunkWriter nor OpenWriterAt supported") return nil, errors.New("multi-thread copy: neither OpenChunkWriter nor OpenWriterAt supported")
} }
openChunkWriter = openChunkWriterFromOpenWriterAt(openWriterAt, int64(ci.MultiThreadChunkSize), int64(ci.MultiThreadWriteBufferSize), f) openChunkWriter = openChunkWriterFromOpenWriterAt(openWriterAt, int64(ci.MultiThreadChunkSize), int64(ci.MultiThreadWriteBufferSize), f)
// We don't seek the chunks with OpenWriterAt
noseek = true
} }
if src.Size() < 0 { if src.Size() < 0 {
@ -184,7 +187,7 @@ func multiThreadCopy(ctx context.Context, f fs.Fs, remote string, src fs.Object,
partSize: chunkSize, partSize: chunkSize,
streams: streams, streams: streams,
numChunks: numChunks, numChunks: numChunks,
noSeek: f.Features().PartialUploads, noSeek: noseek,
} }
// Make accounting // Make accounting