TrueCloudLab/rclone
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions 1

mount, cmount: remove addition of O_CREATE to flags on file open #2141

Browse source 
Previously this was adding it in to all file opens which was causing
inefficiencies under Windows where it stats the file using
open/fstat/close.

This change will make stat operations run much quicker under Windows
as they won't have to open the underlying file

This problem was introduced in61b6159a05336bd7ba105766de2d2ff171f7fb81
where we added O_CREATE to all file opens and creates.
This commit is contained in:
Nick Craig-Wood 2018-03-15 10:27:04 +00:00
parent 0a0318df20
commit 34c45a7c04
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cmd/cmount/fs.go
View file

@ -283,7 +283,7 @@ func (fsys *FS) Open(path string, flags int) (errc int, fh uint64) {
defer log.Trace(path, "flags=0x%X", flags)("errc=%d, fh=0x%X", &errc, &fh)
// translate the fuse flags to os flags
flags = translateOpenFlags(flags) | os.O_CREATE
flags = translateOpenFlags(flags)
handle, err := fsys.VFS.OpenFile(path, flags, 0777)
if errc != 0 {
return translateError(err), fhUnset

6
cmd/mount/file.go
View file

@ -3,7 +3,6 @@
package mount
import (
"os"
"time"
"bazil.org/fuse"
@ -69,10 +68,7 @@ func (f *File) Open(ctx context.Context, req *fuse.OpenRequest, resp *fuse.OpenR
// fuse flags are based off syscall flags as are os flags, so
// should be compatible
//
// we seem to be missing O_CREATE here so add it in to allow
// file creation
handle, err := f.File.Open(int(req.Flags) | os.O_CREATE)
handle, err := f.File.Open(int(req.Flags))
if err != nil {
return nil, translateError(err)
}