TrueCloudLab/rclone
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

rc: pass response writer when needsResponse is set instead of pointer

Browse source 
rc: Fix failing tests for *http.ResponseWriter
This commit is contained in:
Chaitanya Bankanhal 2020-08-15 23:33:07 +05:30 committed by Nick Craig-Wood
parent a9713cd0ed
commit 6308153ae7
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
fs/rc/params.go
View file

@ -120,7 +120,7 @@ func (p Params) GetHTTPResponseWriter() (*http.ResponseWriter, error) {
} }
request, ok := value.(*http.ResponseWriter) request, ok := value.(*http.ResponseWriter)
if !ok { if !ok {
return nil, ErrParamInvalid{errors.Errorf("expecting http.ResponseWriter value for key %q (was %T)", key, value)} return nil, ErrParamInvalid{errors.Errorf("expecting *http.ResponseWriter value for key %q (was %T)", key, value)}
} }
return request, nil return request, nil
} }

2
fs/rc/rcserver/rcserver.go
View file

@ -266,7 +266,7 @@ func (s *Server) handlePost(w http.ResponseWriter, r *http.Request, path string)
} }
if call.NeedsResponse { if call.NeedsResponse {
in["_response"] = &w in["_response"] = w
} }
// Check to see if it is async or not // Check to see if it is async or not