TrueCloudLab/rclone
16
0
Fork 4
Code Issues 1 Pull requests Projects Releases 4 Packages Wiki Activity Actions

local: fix crash with --metadata on Android

Browse source 
Before this change we called statx which causes a

    SIGSYS: bad system call

fault.

After this we force Android to use fstatat

Fixes #7006
This commit is contained in:
Nick Craig-Wood 2023-05-17 12:51:26 +01:00
parent f489b54fa0
commit a6cf4989b6
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
backend/local/metadata_linux.go
View file

@ -5,6 +5,7 @@ package local
import ( import (
"fmt" "fmt"
"runtime"
"sync" "sync"
"time" "time"
@ -23,7 +24,7 @@ func (o *Object) readMetadataFromFile(m *fs.Metadata) (err error) {
// Check statx() is available as it was only introduced in kernel 4.11 // Check statx() is available as it was only introduced in kernel 4.11
// If not, fall back to fstatat() which was introduced in 2.6.16 which is guaranteed for all Go versions // If not, fall back to fstatat() which was introduced in 2.6.16 which is guaranteed for all Go versions
var stat unix.Statx_t var stat unix.Statx_t
if unix.Statx(unix.AT_FDCWD, ".", 0, unix.STATX_ALL, &stat) != unix.ENOSYS { if runtime.GOOS != "android" && unix.Statx(unix.AT_FDCWD, ".", 0, unix.STATX_ALL, &stat) != unix.ENOSYS {
readMetadataFromFileFn = readMetadataFromFileStatx readMetadataFromFileFn = readMetadataFromFileStatx
} else { } else {
readMetadataFromFileFn = readMetadataFromFileFstatat readMetadataFromFileFn = readMetadataFromFileFstatat