From a9585efd6456608c25653def916e8e31a4018f99 Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Thu, 26 Nov 2020 12:10:46 +0000 Subject: [PATCH] dropbox: make malformed_path errors from too long files not retriable Before this change, rclone would retry files with filenames that were too long again and again. This changed recognises the malformed_path error that is returned and marks it not to be retried which stops unnecessary retrying of the file. See #4805 --- backend/dropbox/dropbox.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/backend/dropbox/dropbox.go b/backend/dropbox/dropbox.go index 854bc798d..180cd9551 100755 --- a/backend/dropbox/dropbox.go +++ b/backend/dropbox/dropbox.go @@ -254,9 +254,11 @@ func shouldRetry(err error) (bool, error) { return false, err } baseErrString := errors.Cause(err).Error() - // First check for Insufficient Space + // First check for specific errors if strings.Contains(baseErrString, "insufficient_space") { return false, fserrors.FatalError(err) + } else if strings.Contains(baseErrString, "malformed_path") { + return false, fserrors.NoRetryError(err) } // Then handle any official Retry-After header from Dropbox's SDK switch e := err.(type) {