TrueCloudLab/rclone
16
0
Fork 4
Code Issues 1 Pull requests Projects Releases 4 Packages Wiki Activity Actions

copyurl: fix copying files that return HTTP errors

Browse source
This commit is contained in:
Nick Craig-Wood 2019-08-05 19:20:50 +01:00
parent e502be475a
commit d0c65b4c5e
2 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
fs/operations/operations_test.go
View file

@ -695,7 +695,11 @@ func TestCopyURL(t *testing.T) {
fstest.CheckItems(t, r.Fremote)
// check when reading from regular HTTP server
status := 0
handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if status != 0 {
http.Error(w, "an error ocurred", status)
}
_, err := w.Write([]byte(contents))
assert.NoError(t, err)
})
@ -708,6 +712,14 @@ func TestCopyURL(t *testing.T) {
fstest.CheckListingWithPrecision(t, r.Fremote, []fstest.Item{file1}, nil, fs.ModTimeNotSupported)
// Check an error is returned for a 404
status = http.StatusNotFound
o, err = operations.CopyURL(context.Background(), r.Fremote, "file1", ts.URL)
require.Error(t, err)
assert.Contains(t, err.Error(), "Not Found")
assert.Nil(t, o)
status = 0
// check when reading from unverified HTTPS server
fs.Config.InsecureSkipVerify = true
fshttp.ResetTransport()