TrueCloudLab/rclone
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions 1

operations: fix TestCaseInsensitiveMoveFileDryRun on chunker integration tests #7591

Browse source 
It appears that ci.DryRun = true affects the behavior of r.WriteObject on
chunker only, and no other remotes. This change puts a quick bandaid on it by
setting it later on in the test, but perhaps the underlying issue warrants a
closer look at some point... is chunker checking ci.DryRun itself in a way that
no other remote does? If so, should it? (Does this break encapsulation?)
This commit is contained in:
nielash 2024-01-23 16:51:07 -05:00 committed by Nick Craig-Wood
parent d2b37cf61e
commit f3680d222c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
fs/operations/operations_test.go
View file

@ -1005,10 +1005,10 @@ func TestCaseInsensitiveMoveFileDryRun(t *testing.T) {
return return
} }
ci.DryRun = true
file1 := r.WriteObject(ctx, "hello", "world", t1) file1 := r.WriteObject(ctx, "hello", "world", t1)
r.CheckRemoteItems(t, file1) r.CheckRemoteItems(t, file1)
ci.DryRun = true
err := operations.MoveFile(ctx, r.Fremote, r.Fremote, "HELLO", file1.Path) err := operations.MoveFile(ctx, r.Fremote, r.Fremote, "HELLO", file1.Path)
require.NoError(t, err) require.NoError(t, err)
r.CheckRemoteItems(t, file1) r.CheckRemoteItems(t, file1)