Consider reorganizing map access #9

New issue

Closed

opened 2025-01-29 13:09:15 +00:00 by alexvanin · 0 comments

alexvanin commented

2025-01-29 13:09:15 +00:00

Owner

Access to containerIDCache is protected by mutex. However mutex locks sometimes are far away from map access, e.g. resolveContainerIDHelper() reads the data without mutex, but it is correct because callers lock the mutex (see resolveOrCreateContainer).

To make code a bit more error prone, we can change the way to access mutex data. Two ways to deal with it:

create small function to read / write data from the map use locks only in these small function
add some copy-paste to existing functions that use locks

Read more in discussion here: #6 (comment)

Access to `containerIDCache` is protected by mutex. However mutex locks sometimes are far away from map access, e.g. `resolveContainerIDHelper()` reads the data without mutex, but it is correct because callers lock the mutex (see resolveOrCreateContainer). To make code a bit more error prone, we can change the way to access mutex data. Two ways to deal with it: - create small function to read / write data from the map use locks only in these small function - add some copy-paste to existing functions that use locks Read more in discussion here: https://git.frostfs.info/TrueCloudLab/rclone/pulls/6#issuecomment-64971